Skip to content

don't assume os.Stdout and rely on dockerCLI.streams - #10082

Merged
ndeloof merged 1 commit into
docker:v2from
ndeloof:stdout
Dec 20, 2022
Merged

ndeloof merged 1 commit into
docker:v2from
ndeloof:stdout

Conversation

@ndeloof

@ndeloof ndeloof commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

What I did
avoid use of os.Stdout and prefer dockerCli.Out()

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@codecov

codecov Bot commented Dec 15, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 76.98% // Head: 76.98% // No change to project coverage 👍

Coverage data is based on head (e170a3d) compared to base (9d12eec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10082   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files           2        2           
  Lines         252      252           
=======================================
  Hits          194      194           
  Misses         51       51           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof
ndeloof force-pushed the stdout branch 3 times, most recently from 72f4ab2 to 1f603f7 Compare December 15, 2022 10:53
@ndeloof
ndeloof requested review from glours, milas, nicksieger and ulyssessouza and removed request for milas and nicksieger December 15, 2022 11:35

@milas milas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Comment thread cmd/compose/compose.go Resolved
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

@laurazard laurazard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof
ndeloof merged commit 24f8327 into docker:v2 Dec 20, 2022
@ndeloof
ndeloof deleted the stdout branch December 20, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants