Fix PlatformTarget validation for RuntimeIdentifiers - #12188
Merged
jonathanpeppers merged 1 commit intoJul 21, 2026
Merged
Conversation
Android per-RID inner builds assign RuntimeIdentifier after the outer assembly has already been compiled. Run the common configuration validation hook before reusing that assembly so incompatible PlatformTarget and RID combinations fail with NETSDK1032 instead of crashing at runtime. Add a regression test for PlatformTarget=x64 with RuntimeIdentifiers=android-arm64. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c072388c-788f-44a1-9b09-824dfe7c1d6c
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build-time validation gap in Android’s per-RuntimeIdentifier inner builds: when RuntimeIdentifier is only assigned in the RID-specific inner build, an incompatible outer-built managed assembly (e.g., PlatformTarget=x64) could be reused for android-arm64, leading to runtime crashes. The change forces MSBuild’s common configuration/platform validation to run before the outer assembly is reused, producing the expected NETSDK1032 error instead of a runtime failure.
Changes:
- Run
_CheckForInvalidConfigurationAndPlatformas part of_ComputeFilesToPublishForRuntimeIdentifiersso incompatiblePlatformTarget/RID combinations fail during the inner build. - Add a unit test that asserts the build fails and reports
NETSDK1032forandroid-arm64+Platform=x64.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest2.cs | Adds a regression test ensuring incompatible Platform + RuntimeIdentifiers fails with NETSDK1032. |
| src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets | Ensures MSBuild configuration/platform validation runs before reusing the outer intermediate assembly in RID inner builds. |
jonathanpeppers
added
the
ready-to-review
jonathanpeppers
commented
Jul 20, 2026
Comment on lines
+66
to
+73
| <!-- RuntimeIdentifier is assigned in these inner builds, after the outer assembly has been compiled. | ||
| _CheckForInvalidConfigurationAndPlatform is a private MSBuild target, but there is no public | ||
| validation-only target. Microsoft.Common.targets explicitly directs custom targets that require | ||
| configuration validation to depend on it. This also avoids depending on the SDK's private | ||
| _CheckForMismatchingPlatform implementation target. | ||
| See https://github.com/dotnet/msbuild/blob/eae54023463db15e9a9081f35a959c9162797643/src/Tasks/Microsoft.Common.CurrentVersion.targets#L823-L836 --> | ||
| <Target Name="_ComputeFilesToPublishForRuntimeIdentifiers" | ||
| DependsOnTargets="BuildOnlySettings;_FixupIntermediateAssembly;_PatchNuGetReferenceMetadata;ResolveReferences;ComputeFilesToPublish;$(_RunAotMaybe)" | ||
| DependsOnTargets="BuildOnlySettings;_CheckForInvalidConfigurationAndPlatform;_FixupIntermediateAssembly;_PatchNuGetReferenceMetadata;ResolveReferences;ComputeFilesToPublish;$(_RunAotMaybe)" |
Member
Author
There was a problem hiding this comment.
I could find no other public target we can use here, but they actually say to use the private target here:
rolfbjarne
approved these changes
Jul 21, 2026
jonathanpeppers
enabled auto-merge (squash)
July 21, 2026 13:18
jonathanpeppers
deleted the
jonathanpeppers-investigate-platformtarget-x64
branch
July 21, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android's per-RID inner builds assign
RuntimeIdentifierafter the outer assembly has already been compiled. This allowed an x64 managed assembly to be reused forandroid-arm64, producing an application that built successfully but crashed at runtime.Run the common MSBuild configuration validation hook before reusing the outer assembly so incompatible combinations fail with
NETSDK1032. The target is private, but Microsoft.Common.targets explicitly directs custom targets requiring configuration validation to depend on it; the source comment includes a permanent link documenting that contract.Fixes #12183
Tests:
IncompatiblePlatformTargetAndRuntimeIdentifiersFailsBuildBuildBasicApplicationThenMoveIt