Repository navigation
[net11.0] Bump min macOS to 14.0, and iOS/tvOS to 13.0. Fixes #23784. - #24420
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dalexsoto
left a comment
There was a problem hiding this comment.
Up to you if you want to change this Mr. Rolf from Earth-199999 😁
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
50eaeac to
278a770
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…a version we actually support.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
❌ [CI Build #c33fab1] Tests on macOS M1 - Mac Ventura (13) failed ❌Failed tests are:
Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
❌ [CI Build #c33fab1] Tests on macOS M1 - Mac Monterey (12) failed ❌Failed tests are:
Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #8b8188b] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #8b8188b] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #8b8188b] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #8b8188b] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #8b8188b] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #8b8188b] Build passed (Detect API changes) ✅Pipeline on Agent |
🚀 [CI Build #8b8188b] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 136 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
…23784. (dotnet#24420) Fixes dotnet#23784. This PR might be easiest to review commit-by-commit. (cherry picked from commit 782cd38)
…umps. Fixes #27041 (#27084) In #25691, commits #24420 (bumping the minimum macOS version to 14.0 and iOS/tvOS to 13.0 for .NET 11) and #24515 (bumping the minimum Mac Catalyst version to 17.0 for .NET 11) were backported to the `xcode27.0` (.NET 10) branch alongside the Xcode 27 iOS/tvOS 15.0 deployment target bump. While Xcode 27 requires iOS and tvOS 15.0 as the minimum deployment target (both in `SDKSettings.plist` and `libc++`), macOS (12.0) and Mac Catalyst (15.0) were already at or above the Xcode 27 SDK floor and did not need to be raised in .NET 10. This PR reverts the macOS and Mac Catalyst minimum OS version bumps on `release/10.0.1xx`: * Restore `DOTNET_MIN_MACOS_SDK_VERSION=12.0` and `DOTNET_MIN_MACCATALYST_SDK_VERSION=15.0` in `Make.config` and `tools/common/SdkVersions.cs`. * Restore the pre-14.0 macOS and pre-17.0 Mac Catalyst `KnownVersions` entries in `builds/Versions-macOS.plist.in` and `builds/Versions-MacCatalyst.plist.in`. * Restore default `SupportedOSPlatformVersion` / deployment targets in macOS and Mac Catalyst project templates and test plists. * Restore the `[Mac (...)]`, `[SupportedOSPlatform ("macos*")]`, and `[SupportedOSPlatform ("maccatalyst*")]` availability attributes across `src/` and update `tests/bgen` and `tests/dotnet/UnitTests/ProjectTest.cs` accordingly. Fixes #27041 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fixes #23784.
This PR might be easiest to review commit-by-commit.