[dotnet] Disable trimming when using CoreCLR in the simulator. by rolfbjarne · Pull Request #25315 · dotnet/macios

rolfbjarne · 2026-05-04T15:30:55Z

Co-authored-by: Alex Soto <alex@soto.dev>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

-		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(_SdkIsSimulator)' == 'true' And (!$(RuntimeIdentifier.Contains('arm64')) Or '$(MtouchInterpreter)' != '')">None</_DefaultLinkMode>
+		<!-- Linking is on by default in the simulator when building for arm64, as long as the interpreter is not enabled and using MonoVM -->
+		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(_SdkIsSimulator)' == 'true' And '$(UseMonoRuntime)' == 'true' And $(RuntimeIdentifier.Contains('arm64')) And '$(MtouchInterpreter)' == ''">SdkOnly</_DefaultLinkMode>
+		<!-- Linking is off by default in the simulator when not building for arm64 and using MonOVM -->


-		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(_SdkIsSimulator)' == 'true' And (!$(RuntimeIdentifier.Contains('arm64')) Or '$(MtouchInterpreter)' != '')">None</_DefaultLinkMode>
+		<!-- Linking is on by default in the simulator when building for arm64, as long as the interpreter is not enabled and using MonoVM -->
+		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(_SdkIsSimulator)' == 'true' And '$(UseMonoRuntime)' == 'true' And $(RuntimeIdentifier.Contains('arm64')) And '$(MtouchInterpreter)' == ''">SdkOnly</_DefaultLinkMode>
+		<!-- Linking is off by default in the simulator when not building for arm64 and using MonOVM -->


+		<!-- Default linking is off when using CoreCLR in the simulator -->
+		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(UseMonoRuntime)' != 'true' And '$(_SdkIsSimulator)' == 'true'">None</_DefaultLinkMode>


+		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(UseMonoRuntime)' != 'true' And '$(_PlatformName)' == 'macOS'">None</_DefaultLinkMode>
+
+		<!-- Default linking is off when using CoreCLR in the simulator -->
+		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(UseMonoRuntime)' != 'true' And '$(_SdkIsSimulator)' == 'true'">None</_DefaultLinkMode>


-		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(_SdkIsSimulator)' == 'true' And (!$(RuntimeIdentifier.Contains('arm64')) Or '$(MtouchInterpreter)' != '')">None</_DefaultLinkMode>
+		<!-- Linking is on by default in the simulator when building for arm64, as long as the interpreter is not enabled and using MonoVM -->
+		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(_SdkIsSimulator)' == 'true' And '$(UseMonoRuntime)' == 'true' And $(RuntimeIdentifier.Contains('arm64')) And '$(MtouchInterpreter)' == ''">SdkOnly</_DefaultLinkMode>
+		<!-- Linking is off by default in the simulator when not building for arm64 and using MonoVM -->


vs-mobiletools-engineering-service2 · 2026-05-05T06:37:10Z

✅ [PR Build #3d4e103] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 3d4e10329e16f18fc64d51d12464e09bc90d89aa [PR build]

vs-mobiletools-engineering-service2 · 2026-05-05T06:43:59Z

✅ [PR Build #3d4e103] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 3d4e10329e16f18fc64d51d12464e09bc90d89aa [PR build]

vs-mobiletools-engineering-service2 · 2026-05-05T06:49:33Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3d4e10329e16f18fc64d51d12464e09bc90d89aa [PR build]

vs-mobiletools-engineering-service2 · 2026-05-05T06:59:34Z

✅ [PR Build #3d4e103] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 3d4e10329e16f18fc64d51d12464e09bc90d89aa [PR build]

vs-mobiletools-engineering-service2 · 2026-05-05T11:04:40Z

🚀 [CI Build #3d4e103] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 169 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 13 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 13 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 3d4e10329e16f18fc64d51d12464e09bc90d89aa [PR build]

… CoreCLR. (#35311) ### Description of Change There are a few problems when trimming (LinkSdk) is enabled: * Hot Reload (dotnet watch) doesn't work. * Incremental builds can be slow, because all the SDK assemblies might have be to be re-trimmed and re-R2R'ed again. So remove any custom trimming configuration when using CoreCLR for iOS and Mac Catalyst. The default is (dotnet/macios#25315): * Not trim simulator builds. * Trim device builds. Fixes dotnet/macios#25295.

[dotnet] Disable trimming when using CoreCLR in the simulator.

ccc874e

Copilot AI review requested due to automatic review settings May 4, 2026 15:30

Copilot started reviewing on behalf of rolfbjarne May 4, 2026 15:31 View session

This comment has been minimized.

Sign in to view

dalexsoto approved these changes May 4, 2026

View reviewed changes

Comment thread dotnet/targets/Xamarin.Shared.Sdk.Trimming.props Outdated

This comment has been minimized.

Sign in to view

Update dotnet/targets/Xamarin.Shared.Sdk.Trimming.props

3d4e103

Co-authored-by: Alex Soto <alex@soto.dev>

rolfbjarne requested review from Copilot and removed request for Copilot May 5, 2026 06:20

rolfbjarne enabled auto-merge (squash) May 5, 2026 06:20

Copilot started reviewing on behalf of rolfbjarne May 5, 2026 06:21 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 8f5e478 into main May 5, 2026
53 checks passed

This was referenced May 5, 2026

Don't change the default trimming for iOS and Mac Catalyst when using CoreCLR. dotnet/maui#35311

Merged

[CI Postmortem] Flaky: TestNSurlSessionHandlerCookieContainerSetCookies on macOS #25385

Closed

Copilot AI mentioned this pull request May 13, 2026

fix: treat missing expected cookie as transient network failure in TestNSurlSessionHandlerCookieContainerSetCookie #25420

Merged

3 tasks

		<!-- Default linking is off when using CoreCLR in the simulator -->
		<_DefaultLinkMode Condition="'$(_DefaultLinkMode)' == '' And '$(UseMonoRuntime)' != 'true' And '$(_SdkIsSimulator)' == 'true'">None</_DefaultLinkMode>

Conversation

rolfbjarne commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

vs-mobiletools-engineering-service2 commented May 5, 2026

✅ [PR Build #3d4e103] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 5, 2026

✅ [PR Build #3d4e103] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 5, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 5, 2026

✅ [PR Build #3d4e103] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 5, 2026

🚀 [CI Build #3d4e103] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rolfbjarne commented May 4, 2026 •

edited

Loading