Skip to content

[tests] Ignore the AppSize tests for now. - #25480

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/tests-ignore-appsize
May 20, 2026
Merged

rolfbjarne merged 1 commit into
mainfrom
dev/rolf/tests-ignore-appsize

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

It seems that the results depend on the macOS version of the machine executing
the tests.

That's unfortunate when all my macs are at 26.5 and the bots are at 26.2,
because I can't re-generate the expected app sizes locally.

So ignore these tests until I can come up with a better solution.

It seems that the results depend on the macOS version of the machine executing
the tests.

That's unfortunate when all my macs are at 26.5 and the bots are at 26.2,
because I can't re-generate the expected app sizes locally.

So ignore these tests until I can come up with a better solution.
Copilot AI review requested due to automatic review settings May 20, 2026 08:19
@rolfbjarne
rolfbjarne enabled auto-merge (squash) May 20, 2026 08:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the tests/dotnet app size regression tests by marking the entire AppSizeTest fixture as ignored, due to expected size outputs varying by the macOS version on the machine running the tests.

Changes:

  • Mark the AppSizeTest NUnit fixture as ignored with a message explaining macOS-version-dependent results.

Comment thread tests/dotnet/UnitTests/AppSizeTest.cs
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #1a9c44b] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 1a9c44bb6a1bd90533ec8d9674a6ce54ae9ce185 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #1a9c44b] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 1a9c44bb6a1bd90533ec8d9674a6ce54ae9ce185 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 1a9c44bb6a1bd90533ec8d9674a6ce54ae9ce185 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #1a9c44b] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 1a9c44bb6a1bd90533ec8d9674a6ce54ae9ce185 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #1a9c44b] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 183 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. (⚠️ Html Report Publish failed ⚠️) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 1a9c44bb6a1bd90533ec8d9674a6ce54ae9ce185 [PR build]

@rolfbjarne
rolfbjarne merged commit 77b4057 into main May 20, 2026
53 checks passed
rolfbjarne added a commit that referenced this pull request May 22, 2026
It seems that the results depend on the macOS version of the machine executing
the tests.

That's unfortunate when all my macs are at 26.5 and the bots are at 26.2,
because I can't re-generate the expected app sizes locally.

So ignore these tests until I can come up with a better solution.

Backport of #25480.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants