Skip to content

[release/10.0.1xx] [msbuild] Detect legacy UIKit lifecycle apps built against SDK 27 - #26989

Merged
rolfbjarne merged 9 commits into
release/10.0.1xxfrom
dev/rolf/backport-pr-26936-release/10.0.1xx-2026-10-22
Oct 27, 2026
Merged

rolfbjarne merged 9 commits into
release/10.0.1xxfrom
dev/rolf/backport-pr-26936-release/10.0.1xx-2026-10-22

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Apps that still use the legacy UIKit lifecycle can build successfully with Xcode 27, then crash at launch on iOS or macOS 27. Detect the common missing-scene-manifest case during the build instead, with an actionable error for developers and AI assistants.

Validate the final merged Info.plist for iOS and Mac Catalyst apps built against SDK 27.0 or later. If UIApplicationSceneManifest is missing or is not a dictionary, report MT7199 with migration guidance at https://aka.ms/uiscene. Developers can opt out using <ValidateSceneManifest>false</ValidateSceneManifest>; this only disables the build check, not Apple's runtime requirement.

  • Skip app extensions, frameworks, libraries, other platforms, and older SDKs.
  • Accept an empty dictionary for apps that supply scene configurations dynamically. This is a manifest heuristic, not a verification of delegate or window wiring.
  • Set the property default in Xamarin.Shared.props and track it in the manifest compilation inputs so toggling validation invalidates incremental outputs.
  • Do not write the compiled manifest after validation fails, preventing a later build from skipping the failed check.
  • Document the diagnostic and property, with task-level coverage and iOS/Mac Catalyst build regressions.

Note

🤖 Pull request created by Copilot

Backport of #26936.

rolfbjarne and others added 4 commits October 22, 2026 21:45
Validate the merged iOS and Mac Catalyst app manifest when building against SDK 27.0 or later, before legacy-lifecycle apps reach their native launch-time crash. Report MT7198 with migration guidance at https://aka.ms/uiscene and an explicit ValidateSceneManifest=false escape hatch.

Exclude app extensions, frameworks, other Apple platforms and older SDKs. Accept dynamically configured scenes with an empty manifest dictionary, and include the opt-out in incremental-build inputs. Do not write a successful-looking manifest after validation fails, so repeated builds cannot bypass the error.

Document the property and diagnostic, and cover SDK boundaries, manifest types, partial manifests, exclusions, opt-out behavior and incremental revalidation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move the conditional ValidateSceneManifest=true default from Xamarin.Shared.targets to Xamarin.Shared.props alongside the app-manifest defaults, following the existing property initialization convention. Keep task wiring and incremental-build inputs unchanged, and continue to preserve explicit opt-out values.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Check that the compiled manifest task item is present before using its path in the new scene lifecycle tests. Fail explicitly when the helper's required output is missing instead of suppressing nullable analysis.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Migrate MySingleView to create its window in a scene delegate, and move MyCatalystApp's storyboard into its scene configuration with a registered scene delegate. Both UI apps can now use the scene lifecycle required by SDK 27 without bypassing manifest validation.

Explicitly disable ValidateSceneManifest for generated console-only fixtures, MaxSupportedOSPlatformVersion, and VeryManyRegisteredAssemblies. These executables do not start UIKit, so requiring a scene manifest would obscure the build and registrar behavior they are intended to test. The shared generated-project change also covers the remote Windows entitlements test.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 19:46
@rolfbjarne
rolfbjarne requested a review from mauroa as a code owner October 22, 2026 19:46
@rolfbjarne rolfbjarne added backported ready-to-review This PR is ready to review/merge. labels Oct 22, 2026
@rolfbjarne
rolfbjarne requested a review from dalexsoto as a code owner October 22, 2026 19:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The build regression lacks working invalid-manifest input, and the diagnostic identifier conflicts with the confirmed upstream allocation.

2 open issues
What changed in this PR

Backports build-time detection of legacy UIKit lifecycle apps to release/10.0.1xx, helping developers catch missing scene manifests before SDK 27 apps fail at launch.

Changes:

  • Validates merged iOS and Mac Catalyst manifests, with an opt-out property and incremental-build tracking.
  • Adds task and build regression tests, migrates two test apps to scenes, and exempts console-only fixtures.
  • Documents the validation property, diagnostic, and migration guidance.
File Description
tests/​msbuild/​Xamarin.MacDev.Tasks.Tests/​TaskTests/​CompileAppManifestTaskTests.cs Adds validation, exemption, and partial-manifest tests.
tests/​dotnet/​UnitTests/​TestBaseClass.cs Disables validation for generated console projects.
tests/​dotnet/​UnitTests/​TemplateProjectTest.cs Exempts a console-entry-point fixture.
tests/​dotnet/​UnitTests/​PartialAppManifestTest.cs Adds validation and incremental-build regressions.
tests/​dotnet/​MySingleView/​Info.plist Declares the scene configuration.
tests/​dotnet/​MySingleView/​AppDelegate.cs Moves window creation into a scene delegate.
tests/​dotnet/​MyCatalystApp/​Info.plist Moves storyboard configuration into the scene manifest.
tests/​dotnet/​MyCatalystApp/​AppDelegate.cs Adds a scene delegate.
msbuild/​Xamarin.Shared/​Xamarin.Shared.targets Passes and tracks the validation property.
msbuild/​Xamarin.Shared/​Xamarin.Shared.props Enables validation by default.
msbuild/​Xamarin.MacDev.Tasks/​Tasks/​CompileAppManifest.cs Validates scenes and avoids saving after validation errors.
msbuild/​Xamarin.Localization.MSBuild/​MSBStrings.resx Adds the migration diagnostic text.
docs/​website/​mtouch-errors.md Documents the new diagnostic.
docs/​building-apps/​build-properties.md Documents validation scope and opt-out behavior.

Review effort: Balanced

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

dalexsoto
dalexsoto previously approved these changes Oct 22, 2026
Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:37
@rolfbjarne rolfbjarne removed the ready-to-review This PR is ready to review/merge. label Oct 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new build regression relies on manifest override properties that this backport does not consume, so its expected-failure checks cannot exercise MT7199.

1 open issue
1 resolved since last review

Review effort: Balanced

The .NET 10 release branch does not have the framework-output support that introduced CompileAppManifest.IsFramework on main. Remove the framework exemption from the backported scene lifecycle validator and its tests instead of referencing a task property that does not exist on this branch.

Keep coverage for SDK version gating, supported platforms, app extensions, the validation opt-out, and merged scene manifests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:48
@rolfbjarne
rolfbjarne removed the request for review from mauroa October 22, 2026 21:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The build regression relies on manifest properties that its backport fixture does not consume, so its expected-failure assertions cannot exercise the intended invalid manifest.

1 open issue

Review effort: Balanced

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 06:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new build regression expects validation errors on SDKs below 27.0, where validation is intentionally disabled.

2 open issues

Review effort: Balanced

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

The release branch does not support AppManifestEntry, and MyPartialAppManifestApp never consumes ManifestKey or ManifestValue. Setting those properties leaves the shared scene manifest valid, so the build unexpectedly succeeds.

Allow the test app to include an additional partial manifest and have the regression test supply an invalid UIApplicationSceneManifest through that supported path. Preserve coverage for repeated validation failures, opting out, re-enabling validation, and restoring a valid manifest without backporting an unrelated feature.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Apple-platform CI and launch validation remain necessary to confirm the default-on check, incremental-build behavior, and UIKit fixture migrations.

1 open issue
1 resolved since last review

Review effort: Balanced

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 44b5f46f309bebe4727acc0615244d445cfd79ca [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #44b5f46] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 200 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 19 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Golden Gate (27): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 44b5f46f309bebe4727acc0615244d445cfd79ca [PR build]

@rolfbjarne rolfbjarne added the ready-to-review This PR is ready to review/merge. label Oct 26, 2026
@rolfbjarne
rolfbjarne enabled auto-merge (squash) October 26, 2026 20:01
@rolfbjarne
rolfbjarne merged commit 8d2dffe into release/10.0.1xx Oct 27, 2026
56 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/backport-pr-26936-release/10.0.1xx-2026-10-22 branch October 27, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported ready-to-review This PR is ready to review/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants