You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remote Windows publishing collects application artifact metadata after Build has disconnected from the paired Mac. Passing the build session to ReadAppManifest then attempts another remote task without an associated application, causing the reported ArgumentNullException for path2.
WriteAppManifest already downloads the final merged bundle manifest to Windows. Read that local file without a remote session, require it to exist, and disable the unused minimum OS version conversion so metadata collection does not need the Mac SDK.
Add four RemoteWindows regression cases covering GetApplicationArtifacts and Publish, with archiving enabled and disabled. They verify final-manifest availability and custom application metadata, including the bundle-name fallback. Existing remote IPA/archive coverage only invoked Build; the metadata and publish tests were not selected by the remote Windows category filter.
The tests disable the independent publish-time dSYM copy to isolate this fix. That connection-ordering issue is being addressed separately. A .NET 10 backport also needs the explicit manifest download from commit b44b2f9698.
…6904)
Remote Windows publishing collects application artifact metadata after `Build` has disconnected from the paired Mac. Passing the build session to `ReadAppManifest` then attempts another remote task without an associated application, causing the reported `ArgumentNullException` for `path2`.
`WriteAppManifest` already downloads the final merged bundle manifest to Windows. Read that local file without a remote session, require it to exist, and disable the unused minimum OS version conversion so metadata collection does not need the Mac SDK.
Add four `RemoteWindows` regression cases covering `GetApplicationArtifacts` and `Publish`, with archiving enabled and disabled. They verify final-manifest availability and custom application metadata, including the bundle-name fallback. Existing remote IPA/archive coverage only invoked `Build`; the metadata and publish tests were not selected by the remote Windows category filter.
The tests disable the independent publish-time dSYM copy to isolate this fix. That connection-ordering issue is being addressed separately. A .NET 10 backport also needs the explicit manifest download from commit `b44b2f9698`.
Fixes#26847
🤖 Pull request created by Copilot
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This backport addresses remote Windows publishing failures from #26847 by reading application artifact metadata locally after the paired Mac disconnects.
Changes:
Downloads the final bundle manifest to Windows and supports single-item calls to the copy helper.
Changes artifact metadata collection to read the local manifest without a remote session.
Adds four remote Windows regression cases covering artifact collection and publishing, with archiving enabled and disabled.
File
Description
tests/dotnet/UnitTests/PostBuildTest.cs
Adds remote Windows manifest and artifact metadata checks.
msbuild/Xamarin.Shared/Xamarin.Shared.targets
Switches metadata reads to the local manifest and requests skipping minimum OS processing.
Backport the DisableMinimumOSVersion property from commit 5cc77af
so _AddAppleApplicationArtifactMetadata can disable minimum OS version
conversion on release/10.0.1xx.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
All four new RemoteWindows cases need validation on paired Windows/Mac machines because the external messaging client’s post-disconnection transfer behavior cannot be verified from the source snapshot.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Validate AppBundleManifest before use instead of suppressing nullability
⚠️ The new AppBundleManifest! suppresses nullability instead of validating the task input, contrary to the entry-point null-check convention in .github/copilot-instructions.md:182-186. Check AppBundleManifest at the start of Execute and pass it to the copy helper without the null-forgiving operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote Windows publishing collects application artifact metadata after
Buildhas disconnected from the paired Mac. Passing the build session toReadAppManifestthen attempts another remote task without an associated application, causing the reportedArgumentNullExceptionforpath2.WriteAppManifestalready downloads the final merged bundle manifest to Windows. Read that local file without a remote session, require it to exist, and disable the unused minimum OS version conversion so metadata collection does not need the Mac SDK.Add four
RemoteWindowsregression cases coveringGetApplicationArtifactsandPublish, with archiving enabled and disabled. They verify final-manifest availability and custom application metadata, including the bundle-name fallback. Existing remote IPA/archive coverage only invokedBuild; the metadata and publish tests were not selected by the remote Windows category filter.The tests disable the independent publish-time dSYM copy to isolate this fix. That connection-ordering issue is being addressed separately. A .NET 10 backport also needs the explicit manifest download from commit
b44b2f9698.Fixes #26847
🤖 Pull request created by Copilot
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
Backport of #26904.