Repository navigation
[ci-fix] De-flake ShellContentShouldRespectSafeAreaEdges_After_Navigation: wait before tap (refs #37653) - #37999
Conversation
…pt 1/10) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
|
♻️ Attempt 1/10: red is an unrelated infrastructure/build flake on the macOS Release build leg: MSBuild terminated with an unhandled
|
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
This PR de-flakes the Issue32941 UI test by adding deterministic synchronization before the first navigation interaction, reducing timing races in CI without changing any assertions or product behavior.
Changes:
- Add an explicit
WaitForElement("GoToSignOutButton")immediately before tapping the button inShellContentShouldRespectSafeAreaEdges_After_Navigation().
File summaries
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32941.cs | Adds a readiness wait for the exact element being tapped to avoid intermittent navigation timing failures. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Workflow artifact: ci-fix
Artifact kind: deflake
Refs: #37653
Target branch: main
Attempt: 1/10
Attempt 1 of 10
Wait for the Shell navigation button to be ready before the test taps it.
Previous attempts (prior commits on this PR)
No prior attempts.
This attempt differs by adding deterministic synchronization at the first interaction rather than changing product behavior, increasing a timeout, or retrying the test.
Root cause
The CI log reports
ShellContentShouldRespectSafeAreaEdges_After_Navigationtiming out while waiting for the expected element. InIssue32941.cs, the test waited forMainPageLabeland then immediately tappedGoToSignOutButton; the button could still be unavailable while the Shell page finished mounting.Flake class: test-quality
Why this was flaky
The test synchronized on a label that proves the initial page is visible, but not on the separate button it interacts with. In build 1573324 the test failed after 18 seconds and then passed in 3 seconds on retry, which is consistent with that readiness race rather than a deterministic safe-area failure.
De-flake
The test now calls
WaitForElement("GoToSignOutButton")immediately beforeTap. No assertion was weakened, no timeout was increased, and no retry attribute was added.Fix
Add the repository-standard readiness wait for the exact element being tapped. This is the smallest correction to the test interaction and leaves the navigation and safe-area assertions unchanged.
What is unverified / where I need help
Validation
not run because no Android UI-test device rig is available in this runnerEvidence
Filed by
ci-status-fix. This is the single PR for #37653: the workflow watches its own CI and pushes up to 10 attempts on this same PR (it never opens a second PR). It advances only when the fix's own build settles red and that red is caused by the fix. Comments, reviews, and commits do not transfer ownership; the loop remains autonomous until this PR is closed. EligibleCHANGES_REQUESTEDreviews are handled through Track C. After 10 attempts it stops and defers to humans. In round 1 a maintainer still needs to comment/azp run maui-pr(plus the gated uitests/devicetests legs when relevant) to exercise each new commit.