Fix slnf test assets to use \\ - #51791
Merged
Youssef1313 merged 3 commits intoNov 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the path separator convention in solution filter (.slnf) test assets to use double backslashes (\\) instead of forward slashes. The change aligns these test assets with the JSON format standard and the existing convention used in all other .slnf files in the repository, where backslashes must be escaped in JSON strings.
Key Changes:
- Updated path separators from
/to\\in .slnf test asset files to match the repository-wide convention
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/TestAssets/TestProjects/MultiTestProjectSolutionWithTests/TestProjects.slnf | Changed project path separator from / to \\ |
| test/TestAssets/TestProjects/MultiTestProjectSolutionWithTests/SolutionFilter/OtherTestProjects.slnf | Changed both solution path and project path separators from / to \\ |
Youssef1313
force-pushed
the
dev/ygerges/update-slnf-test-assets
branch
from
November 18, 2025 10:52
57fe217 to
f3e246b
Compare
Member
Author
Let's see after #51411. |
Youssef1313
force-pushed
the
dev/ygerges/update-slnf-test-assets
branch
from
November 18, 2025 12:16
f3e246b to
9b50da6
Compare
fhnaseer
approved these changes
Nov 18, 2025
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51521
I think the PR might fail currently, but hopefully will pass after #51411 is merged.