Repository navigation
ConcurrentGC Refactoring & SATB Tuning Methods - #5889
Conversation
|
Much of
|
|
/* If the segment is for a concurrently collectable subspace we will * have some cards to clear too */
if ((subspace->isConcurrentCollectable()) && (_extensions->configuration->isIncrementalUpdateBarrierEnabled())) {
_numInitRanges += 2; /* We will have some cards to clean as well */
} else {
_numInitRanges += 1;
}if (!_initSetupDone ) {
_markingScheme->getWorkPackets()->reset(env);
_markingScheme->workerSetupForGC(env);
if(NULL != _cardTable) {
((MM_ConcurrentCardTable *)_cardTable)->initializeCardCleaning(env);
}
_initSetupDone = true;
}Edit: This no longer applies with the latest changes |
91b7fa8 to
1f0b410
Compare
3ce3cfe to
5d3536a
Compare
|
Latest commit removes
|
0097b7a to
5e08f17
Compare
9673667 to
a8bf24c
Compare
ffe20c4 to
011c9ad
Compare
|
Jenkins build all |
|
Bah. I didn't notice the earlier CI build failures before launching Jenkins build. Please fix. |
adcfbca to
ea30e4f
Compare
|
Fixed the previous compile issue, looking into the test failure now |
d942dba to
3ba357a
Compare
|
Turns out the issue was from changing + for (uint32_t x = (initIndex - 1); x >= 0; x--) correct conversion is signed int32 Everything else looks good, I'll clean up commit history and this should be good to merge |
c33f6f4 to
ae8ce9f
Compare
These changes are to generalize the ConcurrentGC Collector Class so that it can be used for both IncrementalUpdate and SATB style of Concurrent Marking. They are a pre-req to introducing SATB since the existing concurrent collector class is closely tied to Incremental Update approach. CM enabling functionality needs to be abstracted - card table/cleaning cards must be extracted to the derived IncrementalUpdate class. Since there hasn't been any other implementation prior to SATB, ConcurrentGC has acted as Incremental Update Concurrent Collector, much of the components (e.g state machine, Initing, Tuning/adaptive parameters, concurrent state/phases, verbose logging, etc) can be reused with this rework by extracting card/barrier specific code. - ConcurrentGC class is now an Abstract Class _(removed newInstance function)_ - Card cleaning specific adaptive params/factors moved to Incremental Update - Common (Generalized) logic & vars given Protected access in Concurrent GC - New methods introduced to help common up shared logic - signalThreadsToActivateWriteBarrierInternal - updateTuningStatisticsInternal - resetConcurrentParameters - preCompleteConcurrentCycle - finalConcurrentPrecollect - getTraceTarget - External WB Entry points now call new collector specific handlers - J9ConcurrentWriteBarrierBatchStoreHandler - J9ConcurrentWriteBarrierStoreHandler **Tuning logic Implemented for SATB** - adjustTraceTarget - tuneToHeap Signed-off-by: Salman Rana <salman.rana@ibm.com>
ae8ce9f to
3d87347
Compare
|
Jenkins build all |
0xdaryl
left a comment
There was a problem hiding this comment.
Windows CI failure occurred after tests were run successfully.
These changes are to generalize the ConcurrentGC Collector so that it can be used for both: IncrementalUpdate and SATB style of Concurrent Marking. They are a pre-req to introducing SATB since the existing concurrent collector class is closely tied to the Incremental Update approach.
CM enabling functionality needs to be abstracted - card table/cleaning cards must be extracted to the derived IncrementalUpdate class. Because that there hasn't been any other implementation prior to SATB, ConcurrentGC has acted as an Concurrent Incremental Update Collector, much of the components (e.g state machine, Initing, Tuning/adaptive parameters, concurrent state/phases, verbose logging, etc) can be reused with this rework.
ConcurrentGC class is now an Abstract Class (removed newInstance function and introduced pure virtual functions)
Card cleaning specific adaptive params/factors moved to Incremental Update
Common (Generalized) logic & vars given Protected access in Concurrent GC
New methods introduced to help common up shared logic (e.g.,
initalizeConcurrentStructures,doConcurrentInitializationInternal,updateTuningStatisticsInternaletc)New WB API specifically for PostStore:
concurrentPostWriteBarrierStoreJ9ConcurrentWriteBarrierBatchStore&J9ConcurrentWriteBarrierStoreTuning logic Implemented for SATB (borrows Incremental logic and simplifies it by not considering 2 pass and cards)
Signed-off-by: Salman Rana salman.rana@ibm.com