Skip to content

Add 'Q' prefix handling - #6183

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:vt-qtype-descriptor
Oct 19, 2021
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:vt-qtype-descriptor

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Handling for Q prefix is added to places as needed.

Related to eclipse-openj9/openj9#12237

@a7ehuo
a7ehuo force-pushed the vt-qtype-descriptor branch from 3b05e3a to 6d374e1 Compare September 23, 2021 19:27
@a7ehuo
a7ehuo force-pushed the vt-qtype-descriptor branch from 6d374e1 to f39c9ee Compare October 15, 2021 17:23
@a7ehuo a7ehuo changed the title WIP: Add 'Q' prefix handling Add 'Q' prefix handling Oct 18, 2021
@a7ehuo
a7ehuo requested review from 0xdaryl and hzongaro October 18, 2021 13:42
@a7ehuo
a7ehuo marked this pull request as ready for review October 18, 2021 13:43
@0xdaryl

0xdaryl commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

@hzongaro : could you review this PR too please?

@0xdaryl

0xdaryl commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just a couple of minor comments that don't affect approval.

Comment thread compiler/il/Aliases.cpp Resolved
Comment thread compiler/optimizer/VPConstraint.cpp Resolved
@a7ehuo
a7ehuo force-pushed the vt-qtype-descriptor branch from f39c9ee to f98cc48 Compare October 18, 2021 20:49
Handling for 'Q' prefix is added to places as needed.

Related to eclipse-openj9/openj9#12237

Co-Authored-By: Yiling Han <Yiling.Han@ibm.com>

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo force-pushed the vt-qtype-descriptor branch from f98cc48 to 6c39a43 Compare October 18, 2021 20:52
@0xdaryl

0xdaryl commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl 0xdaryl self-assigned this Oct 19, 2021
@0xdaryl
0xdaryl merged commit fc21b39 into eclipse-omr:master Oct 19, 2021
@a7ehuo
a7ehuo deleted the vt-qtype-descriptor branch October 12, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants