Repository navigation
Follow up to #5825 - #6184
Merged
Merged
Follow up to #5825#6184
Conversation
cedrichansen
requested review from
charliegracie,
rwy7 and
youngar
as code owners
September 22, 2021 19:39
Contributor
Author
Contributor
|
You could also change the types of to uintptr_t, what should help us remove some explicit casts in OpenJ9 |
This commit contains the follow up items from eclipse-omr#5825 This includes: - making `Trc_MM_MemorySubSpaceTarok_calculateExpandSize_Exit1` and `Trc_MM_MemorySubSpaceTarok_calculateTargetContractSize_Entry` obsolete - `dnssExpectedTimeRatioMaximum` and `dnssExpectedTimeRatioMinimum` were removed, since they are no longer used. The newer version (dnssExpectedRatioMaximum/Minimum) are more flexible for different GC policies - `heapExpansionGCTimeThreshold` and `heapContractionGCTimeThreshold` were removed, since they are no longer used. The newer versions (`heapExpansionGCRatioThreshold` and `heapContractionGCRatioThreshold`) are more flexible for different GC policies Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>
cedrichansen
force-pushed
the
followUpPr
branch
from
September 23, 2021 13:44
14d42bd to
52c3841
Compare
Contributor
Author
Just added that to the change set! |
cedrichansen
added a commit
to cedrichansen/openj9
that referenced
this pull request
Sep 23, 2021
…enure` The data types of the 2 variables mentionned above, have changed from `uint64_t` to `uintptr_t`. With that, several explicit casts were removed, to increase code readibility. Depends on: eclipse-omr/omr#6184 Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>
amicic
approved these changes
Sep 23, 2021
Contributor
Contributor
|
Jenkins build all |
qasimy123
pushed a commit
to qasimy123/openj9-jit-debug-agent
that referenced
this pull request
Nov 26, 2021
…enure` The data types of the 2 variables mentionned above, have changed from `uint64_t` to `uintptr_t`. With that, several explicit casts were removed, to increase code readibility. Depends on: eclipse-omr/omr#6184 Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit contains the follow up items from #5825
This includes:
Trc_MM_MemorySubSpaceTarok_calculateExpandSize_Exit1andTrc_MM_MemorySubSpaceTarok_calculateTargetContractSize_EntryobsoletednssExpectedTimeRatioMaximumanddnssExpectedTimeRatioMinimumwere removed, since they are no longer used. The newer version (dnssExpectedRatioMaximum/Minimum) are more flexible for different GC policiesheapExpansionGCTimeThresholdandheapContractionGCTimeThresholdwere removed, since they are no longer used. The newer versions (heapExpansionGCRatioThresholdandheapContractionGCRatioThreshold) are more flexible for different GC policiesSigned-off-by: Cedric Hansen cedric.hansen@ibm.com