Skip to content

Follow up to #5825 - #6184

Merged
fjeremic merged 1 commit into
eclipse-omr:masterfrom
cedrichansen:followUpPr
Sep 23, 2021
Merged

fjeremic merged 1 commit into
eclipse-omr:masterfrom
cedrichansen:followUpPr

Conversation

@cedrichansen

Copy link
Copy Markdown
Contributor

This commit contains the follow up items from #5825

This includes:

  • making Trc_MM_MemorySubSpaceTarok_calculateExpandSize_Exit1 and Trc_MM_MemorySubSpaceTarok_calculateTargetContractSize_Entry obsolete
  • dnssExpectedTimeRatioMaximum and dnssExpectedTimeRatioMinimum were removed, since they are no longer used. The newer version (dnssExpectedRatioMaximum/Minimum) are more flexible for different GC policies
  • heapExpansionGCTimeThreshold and heapContractionGCTimeThreshold were removed, since they are no longer used. The newer versions (heapExpansionGCRatioThreshold and heapContractionGCRatioThreshold) are more flexible for different GC policies

Signed-off-by: Cedric Hansen cedric.hansen@ibm.com

@cedrichansen

Copy link
Copy Markdown
Contributor Author

@dmitripivkine @amicic

@amicic

amicic commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

You could also change the types of
struct MM_HeapSizingData
uint64_t reservedSize;
uint64_t freeTenure;

to uintptr_t, what should help us remove some explicit casts in OpenJ9

This commit contains the follow up items from eclipse-omr#5825

This includes:
- making `Trc_MM_MemorySubSpaceTarok_calculateExpandSize_Exit1` and `Trc_MM_MemorySubSpaceTarok_calculateTargetContractSize_Entry` obsolete
- `dnssExpectedTimeRatioMaximum` and `dnssExpectedTimeRatioMinimum` were removed, since they are no longer used. The newer version (dnssExpectedRatioMaximum/Minimum) are more flexible for different GC policies
- `heapExpansionGCTimeThreshold` and `heapContractionGCTimeThreshold` were removed, since they are no longer used. The newer versions (`heapExpansionGCRatioThreshold` and `heapContractionGCRatioThreshold`) are more flexible for different GC policies

Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>
@cedrichansen

Copy link
Copy Markdown
Contributor Author

You could also change the types of
struct MM_HeapSizingData
uint64_t reservedSize;
uint64_t freeTenure;

to uintptr_t, what should help us remove some explicit casts in OpenJ9

Just added that to the change set!

cedrichansen added a commit to cedrichansen/openj9 that referenced this pull request Sep 23, 2021
…enure`

The data types of the 2 variables mentionned above, have changed from `uint64_t` to `uintptr_t`.
With that, several explicit casts were removed, to increase code readibility.

Depends on: eclipse-omr/omr#6184

Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>
@amicic

amicic commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

@0xdaryl or @fjeremic please, proceed with final review and merge

@fjeremic

Copy link
Copy Markdown
Contributor

Jenkins build all

@fjeremic
fjeremic merged commit 82faf49 into eclipse-omr:master Sep 23, 2021
qasimy123 pushed a commit to qasimy123/openj9-jit-debug-agent that referenced this pull request Nov 26, 2021
…enure`

The data types of the 2 variables mentionned above, have changed from `uint64_t` to `uintptr_t`.
With that, several explicit casts were removed, to increase code readibility.

Depends on: eclipse-omr/omr#6184

Signed-off-by: Cedric Hansen <cedric.hansen@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants