Skip to content

Define TR_jitLookupDynamic[Public]InterfaceMethod JIT helpers - #6186

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
jdmpapin:jitLookupDynamicInterfaceMethod
Oct 14, 2021
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
jdmpapin:jitLookupDynamicInterfaceMethod

Conversation

@jdmpapin

@jdmpapin jdmpapin commented Sep 27, 2021 •

Copy link
Copy Markdown
Contributor

These new JIT helpers are OpenJ9-specific but unfortunately they still need to be declared here.

@0xdaryl

0xdaryl commented Sep 28, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl

0xdaryl commented Sep 28, 2021

Copy link
Copy Markdown
Contributor

Windows CI passed, failed on infra cleanup step.

@jdmpapin
jdmpapin marked this pull request as draft September 30, 2021 14:50
@jdmpapin

Copy link
Copy Markdown
Contributor Author

Converted to draft until I've addressed eclipse-openj9/openj9#13578 (comment)

@jdmpapin
jdmpapin force-pushed the jitLookupDynamicInterfaceMethod branch from 8637eab to e5512c8 Compare October 13, 2021 20:08
@jdmpapin

Copy link
Copy Markdown
Contributor Author

Pushed an update that also defines a second helper. This contains some in-progress changes where I'm trying to add a comment to the file. It looked like ZZ was the syntax for a comment, but I guess it isn't

Sorry for the noise here - I'm expecting that to test I'll need to rebase, and I want to keep the force-push diffs separate (my revisions vs. rebase)

@jdmpapin
jdmpapin force-pushed the jitLookupDynamicInterfaceMethod branch from e5512c8 to 5c58317 Compare October 13, 2021 20:34
@jdmpapin

Copy link
Copy Markdown
Contributor Author

Deleted the comment in Helpers.inc and added an explanation to the commit message:

The definition of TR_jitLookupDynamicPublicInterfaceMethod uses TR_newArray+2 instead of TR_jitLookupDynamicInterfaceMethod+1 because the latter causes s390m4check.pl to complain that there is a "line longer than 71 characters". It's difficult to add this comment inline next to the definition itself because Helpers.inc is included directly into all of the following file types:

  • C++ header
  • CPP-preprocessed assembly
  • m4-preprocessed assembly

@jdmpapin jdmpapin changed the title Define TR_jitLookupDynamicInterfaceMethod JIT helper Define TR_jitLookupDynamic[Public]InterfaceMethod JIT helpers Oct 13, 2021
These new JIT helpers are OpenJ9-specific but unfortunately they still
need to be declared here.

The definition of TR_jitLookupDynamicPublicInterfaceMethod uses
TR_newArray+2 instead of TR_jitLookupDynamicInterfaceMethod+1 because
the latter causes s390m4check.pl to complain that there is a "line
longer than 71 characters". It's difficult to add this comment inline
next to the definition itself because Helpers.inc is included directly
into all of the following file types:
- C++ header
- CPP-preprocessed assembly
- m4-preprocessed assembly
@jdmpapin
jdmpapin force-pushed the jitLookupDynamicInterfaceMethod branch from 5c58317 to 31a422d Compare October 13, 2021 22:59
@jdmpapin

Copy link
Copy Markdown
Contributor Author

Rebased to bring the branch up to date

@0xdaryl

0xdaryl commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

1 similar comment
@jdmpapin

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@jdmpapin
jdmpapin marked this pull request as ready for review October 14, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants