Repository navigation
Define TR_jitLookupDynamic[Public]InterfaceMethod JIT helpers - #6186
Conversation
|
Jenkins build all |
|
Windows CI passed, failed on infra cleanup step. |
|
Converted to draft until I've addressed eclipse-openj9/openj9#13578 (comment) |
8637eab to
e5512c8
Compare
|
Pushed an update that also defines a second helper. This contains some in-progress changes where I'm trying to add a comment to the file. It looked like ZZ was the syntax for a comment, but I guess it isn't Sorry for the noise here - I'm expecting that to test I'll need to rebase, and I want to keep the force-push diffs separate (my revisions vs. rebase) |
e5512c8 to
5c58317
Compare
|
Deleted the comment in Helpers.inc and added an explanation to the commit message:
|
These new JIT helpers are OpenJ9-specific but unfortunately they still need to be declared here. The definition of TR_jitLookupDynamicPublicInterfaceMethod uses TR_newArray+2 instead of TR_jitLookupDynamicInterfaceMethod+1 because the latter causes s390m4check.pl to complain that there is a "line longer than 71 characters". It's difficult to add this comment inline next to the definition itself because Helpers.inc is included directly into all of the following file types: - C++ header - CPP-preprocessed assembly - m4-preprocessed assembly
5c58317 to
31a422d
Compare
|
Rebased to bring the branch up to date |
|
Jenkins build all |
1 similar comment
|
Jenkins build all |
These new JIT helpers are OpenJ9-specific but unfortunately they still need to be declared here.