Repository navigation
Split _options and _optionString in OptionSet into separate fields - #6195
Merged
Merged
Conversation
When both AOT and JIT have logs specified and when one is processed first, the OptionSet._options for the other one has not been set up properly yet. Since setOptions has not been called for the other command option, getOptions returns a char pointer to _optionString that is implicitly casted as TR::Options * because OptionSet._options and OptionSet._optionString are union. To properly check if OptionSet._options is valid, it needs to be a separate field. Fixes eclipse-omr#6189 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
Contributor
Author
|
@mpirvu Ready for review. Thanks! |
Contributor
|
@0xdaryl Could you please review/merge this simple PR? Thanks |
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both AOT and JIT have logs specified and when one is processed
first, the
OptionSet._optionsfor the other one has not been set upproperly yet. Since
setOptionshas not been called for the othercommand option,
getOptionsreturns a char pointer to_optionStringthat is implicitly casted as
TR::Options *becauseOptionSet._optionsand
OptionSet._optionStringareunion. To properly check ifOptionSet._optionsis valid, it needs to be a separate field.Fixes #6189
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com