Skip to content

Define symbol for new jitAcmpneHelper - #6197

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
hzongaro:define-jitAcmpneHelper-symbol
Oct 7, 2021
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
hzongaro:define-jitAcmpneHelper-symbol

Conversation

@hzongaro

@hzongaro hzongaro commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

The existing jitAcmpHelper symbol can be used in downstream projects to represent object reference comparisons for equality. This change introduces a jitAcmpneHelper symbol to represent inequality comparisons rather than treating that as a second-class operation requiring negation to implement.

The change also renames jitAcmpHelper to jitAcmpeqHelper to clarify the purpose of the existing symbol. The old symbol name will be retained until it is no longer being used by downstream projects.

A subsequent change will introduce a new <objectInequalityComparison> non-helper symbol in the JIT to go along with the existing <objectEqualityComparison> non-helper.

Part of change for OpenJ9 issue #13396.

The existing jitAcmpHelper symbol can be used in downstream projects to
represent object reference comparisons for equality.  This change
introduces a jitAcmpneHelper symbol to represent inequality comparisons
rather than treating that as a second-class operation requiring negation
to implement.

The change also renames jitAcmpHelper to jitAcmpeqHelper to clarify the
purpose of the existing symbol.  The old symbol name will be retained
until it is no longer being used by downstream projects.

Signed-off-by:  Henry Zongaro <zongaro@ca.ibm.com>
@0xdaryl

0xdaryl commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl 0xdaryl self-assigned this Oct 7, 2021
@0xdaryl
0xdaryl merged commit 660dd31 into eclipse-omr:master Oct 7, 2021
@hzongaro
hzongaro deleted the define-jitAcmpneHelper-symbol branch October 8, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants