Repository navigation
Define symbol for new jitAcmpneHelper - #6197
Merged
0xdaryl merged 1 commit intoOct 7, 2021
Merged
Conversation
The existing jitAcmpHelper symbol can be used in downstream projects to represent object reference comparisons for equality. This change introduces a jitAcmpneHelper symbol to represent inequality comparisons rather than treating that as a second-class operation requiring negation to implement. The change also renames jitAcmpHelper to jitAcmpeqHelper to clarify the purpose of the existing symbol. The old symbol name will be retained until it is no longer being used by downstream projects. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
requested review from
0xdaryl,
Leonardo2718,
mstoodle and
vijaysun-omr
as code owners
October 7, 2021 14:31
hzongaro
requested review from
tajila
and removed request for
Leonardo2718,
mstoodle and
vijaysun-omr
October 7, 2021 14:31
tajila
approved these changes
Oct 7, 2021
hangshao0
approved these changes
Oct 7, 2021
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
jitAcmpHelpersymbol can be used in downstream projects to represent object reference comparisons for equality. This change introduces ajitAcmpneHelpersymbol to represent inequality comparisons rather than treating that as a second-class operation requiring negation to implement.The change also renames
jitAcmpHelpertojitAcmpeqHelperto clarify the purpose of the existing symbol. The old symbol name will be retained until it is no longer being used by downstream projects.A subsequent change will introduce a new
<objectInequalityComparison>non-helper symbol in the JIT to go along with the existing<objectEqualityComparison>non-helper.Part of change for OpenJ9 issue #13396.