Repository navigation
Conversation
This change defines a non-helper symbol that can be used by downstream projects to test a pair of object references for an inequality comparison. It is intended to represent the negation of the existing <objectEqualityComparison> non-helper symbol. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
requested review from
0xdaryl,
Leonardo2718,
mstoodle and
vijaysun-omr
as code owners
October 13, 2021 13:56
hzongaro
requested review from
a7ehuo
and removed request for
Leonardo2718,
mstoodle and
vijaysun-omr
October 13, 2021 13:56
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
Oct 13, 2021
a7ehuo
reviewed
Oct 13, 2021
Ensure the aliasing of <objectInequalityComparisonSymbol> in OMR::SymbolReference::getUseDefAliasesBV is handled in the same way as that for <objectEqualityComparisonSymbol>. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
Added the missing entry for <nonNullableArrayNullStoreCheck> to OMR::SymbolReferenceTable::_commonNonHelperSymbolNames. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
Contributor
|
LGTM |
a7ehuo
approved these changes
Oct 13, 2021
Contributor
|
Jenkins build all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change defines a non-helper symbol that can be used by downstream projects to test a pair of object references for an inequality comparison. It is intended to represent the negation of the existing
<objectEqualityComparison>non-helper symbol.