Skip to content

Define <objectInequalityComparison> non-helper - #6203

Merged
0xdaryl merged 3 commits into
eclipse-omr:masterfrom
hzongaro:define-objectInequalityComparison-non-helper
Oct 13, 2021
Merged

0xdaryl merged 3 commits into
eclipse-omr:masterfrom
hzongaro:define-objectInequalityComparison-non-helper

Conversation

@hzongaro

Copy link
Copy Markdown
Contributor

This change defines a non-helper symbol that can be used by downstream projects to test a pair of object references for an inequality comparison. It is intended to represent the negation of the existing <objectEqualityComparison> non-helper symbol.

This change defines a non-helper symbol that can be used by downstream
projects to test a pair of object references for an inequality
comparison.  It is intended to represent the negation of the existing
<objectEqualityComparison> non-helper symbol.

Signed-off-by:  Henry Zongaro <zongaro@ca.ibm.com>
@0xdaryl

0xdaryl commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl 0xdaryl self-assigned this Oct 13, 2021
Comment thread compiler/il/Aliases.cpp Resolved
Ensure the aliasing of <objectInequalityComparisonSymbol> in
OMR::SymbolReference::getUseDefAliasesBV is handled in the same way as that
for <objectEqualityComparisonSymbol>.

Signed-off-by:  Henry Zongaro <zongaro@ca.ibm.com>
Added the missing entry for <nonNullableArrayNullStoreCheck> to
OMR::SymbolReferenceTable::_commonNonHelperSymbolNames.

Signed-off-by:  Henry Zongaro <zongaro@ca.ibm.com>
@a7ehuo

a7ehuo commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

LGTM

@0xdaryl

0xdaryl commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl
0xdaryl merged commit 43e5795 into eclipse-omr:master Oct 13, 2021
@hzongaro
hzongaro deleted the define-objectInequalityComparison-non-helper branch October 13, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants