Repository navigation
AArch64 macOS: Implement omrsignal_context.c - #6215
Merged
Merged
Conversation
keithc-ca
suggested changes
Oct 25, 2021
| "v24", "v25", "v26", "v27", "v28", "v29", "v30", "v31" | ||
| }; | ||
|
|
||
| if (0 <= index && index < sizeof(fpr_names)/sizeof(char *)) { |
Contributor
There was a problem hiding this comment.
Missing parentheses, spaces around /.
Number of elements of an array is better expressed as sizeof(array) / sizeof(array[0]) (then you can't get the element type wrong).
Contributor
There was a problem hiding this comment.
There should be parentheses around every binary operation:
if ((0 <= index) && (index < (sizeof(fpr_names) / sizeof(fpr_names[0])))) {
Contributor
Author
There was a problem hiding this comment.
Changed as suggested.
| "x24", "x25", "x26", "x27", "x28" | ||
| }; | ||
|
|
||
| if (0 <= index && index < sizeof(gpr_names)/sizeof(char *)) { |
Contributor
There was a problem hiding this comment.
As above:
if ((0 <= index) && (index < (sizeof(gpr_names) / sizeof(gpr_names[0])))) {
Contributor
Author
There was a problem hiding this comment.
Changed as suggested.
| case OMRPORT_SIG_CONTROL_PC: | ||
| case 0: | ||
| *name = "PC"; | ||
| *value = (void *)&(threadState->__pc); |
Contributor
There was a problem hiding this comment.
Why the parentheses here and on line 387 (you didn't use them above)?
Contributor
Author
There was a problem hiding this comment.
Removed the parentheses.
This commit implements omrsignal_context.c for AArch64 macOS. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
keithc-ca
approved these changes
Nov 1, 2021
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements omrsignal_context.c for AArch64 macOS.
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com