Skip to content

Add classNameToSignature to ClassEnv - #6219

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:add-classNameToSignature-ClassEnv
Oct 27, 2021
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:add-classNameToSignature-ClassEnv

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Oct 26, 2021 •

Copy link
Copy Markdown
Contributor

This will replace the implementation in Aliases.cpp.
This API adds a new default argument TR_OpaqueClassBlock * to be used to check if the class is a value type or not.

Related to #6217

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

@0xdaryl 0xdaryl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the spelling of "related to" in your commit message please?

Comment thread compiler/env/OMRClassEnv.cpp Resolved
Comment thread compiler/env/OMRClassEnv.hpp Resolved
This will replace the implementation in Aliases.cpp.
This API adds a new default argument `TR_OpaqueClassBlock *`
to be used to check if the class is a value type or not.

Related to eclipse-omr#6217

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo force-pushed the add-classNameToSignature-ClassEnv branch from fee2a64 to cbf479d Compare October 27, 2021 03:55
@0xdaryl

0xdaryl commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl 0xdaryl self-assigned this Oct 27, 2021
@0xdaryl
0xdaryl merged commit 94d9254 into eclipse-omr:master Oct 27, 2021
@a7ehuo
a7ehuo deleted the add-classNameToSignature-ClassEnv branch April 28, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants