Repository navigation
Add classNameToSignature to ClassEnv - #6219
Merged
0xdaryl merged 1 commit intoOct 27, 2021
Merged
Conversation
This was referenced Oct 26, 2021
a7ehuo
force-pushed
the
add-classNameToSignature-ClassEnv
branch
from
October 26, 2021 15:47
f72422f to
fee2a64
Compare
0xdaryl
requested changes
Oct 27, 2021
0xdaryl
left a comment
Contributor
There was a problem hiding this comment.
Can you fix the spelling of "related to" in your commit message please?
This will replace the implementation in Aliases.cpp. This API adds a new default argument `TR_OpaqueClassBlock *` to be used to check if the class is a value type or not. Related to eclipse-omr#6217 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
add-classNameToSignature-ClassEnv
branch
from
October 27, 2021 03:55
fee2a64 to
cbf479d
Compare
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will replace the implementation in Aliases.cpp.
This API adds a new default argument
TR_OpaqueClassBlock *to be used to check if the class is a value type or not.Related to #6217
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com