Skip to content

Port library startup should not return -1 - #6231

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
pshipton:portinit
Nov 8, 2021
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
pshipton:portinit

Conversation

@pshipton

@pshipton pshipton commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

Returning -1 does not give any useful information about what failed.

See also eclipse-openj9/openj9#13872
Issue ibmruntimes/Semeru-Runtimes#5 (comment)
Issue eclipse-openj9/openj9#12526

Returning -1 does not give any useful information about what failed.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton

pshipton commented Nov 5, 2021

Copy link
Copy Markdown
Contributor Author

@keithc-ca can you review this pls.

@keithc-ca keithc-ca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@0xdaryl

0xdaryl commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl

0xdaryl commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

Jenkins build zos

@0xdaryl 0xdaryl self-assigned this Nov 8, 2021
@0xdaryl
0xdaryl merged commit a4b988e into eclipse-omr:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants