Repository navigation
Port library startup should not return -1 - #6231
Merged
Merged
Conversation
Returning -1 does not give any useful information about what failed. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
requested review from
charliegracie,
mstoodle,
rwy7 and
youngar
as code owners
November 5, 2021 21:32
Contributor
Author
|
@keithc-ca can you review this pls. |
keithc-ca
approved these changes
Nov 8, 2021
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
These changes look good to me.
Contributor
|
Jenkins build all |
Contributor
|
Jenkins build zos |
0xdaryl
approved these changes
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning -1 does not give any useful information about what failed.
See also eclipse-openj9/openj9#13872
Issue ibmruntimes/Semeru-Runtimes#5 (comment)
Issue eclipse-openj9/openj9#12526