Repository navigation
Misc. LabelSymbol improvements - #6235
Merged
Merged
Conversation
0xdaryl
commented
Nov 9, 2021
Contributor
- Remove unused LabelSymbol nullCompilationId
- Fix LabelSymbol constructor to always require a CodeGenerator
- Add CodeGenerator parm to LabelSymbol::isPatchBarrier()
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
0xdaryl
requested review from
Leonardo2718,
aviansie-ben,
mstoodle and
vijaysun-omr
as code owners
November 9, 2021 02:30
Contributor
Author
|
Jenkins build all |
* Remove constructor without `CodeGenerator` parameter * Replace `TR::comp()` reach inside each constructor with `CodeGenerator` query * Add missing `_directlyTargeted` field initializaton to all constructors Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Passing in the CodeGenerator object eliminates the need to fetch the Compilation object from `TR::comp()`. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
0xdaryl
force-pushed
the
fixlabelsymbols
branch
from
November 9, 2021 03:34
6eeb98d to
771d2c4
Compare
Contributor
Author
|
Jenkins build all |
Contributor
Author
|
@dsouzai : would you mind reviewing please? |
dsouzai
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.