Skip to content

Misc. LabelSymbol improvements - #6235

Merged
dsouzai merged 3 commits into
eclipse-omr:masterfrom
0xdaryl:fixlabelsymbols
Nov 9, 2021
Merged

dsouzai merged 3 commits into
eclipse-omr:masterfrom
0xdaryl:fixlabelsymbols

Conversation

@0xdaryl

@0xdaryl 0xdaryl commented Nov 9, 2021

Copy link
Copy Markdown
Contributor
  • Remove unused LabelSymbol nullCompilationId
  • Fix LabelSymbol constructor to always require a CodeGenerator
  • Add CodeGenerator parm to LabelSymbol::isPatchBarrier()

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl

0xdaryl commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@0xdaryl 0xdaryl changed the title Misc. LabelSymbol improvements WIP: Misc. LabelSymbol improvements Nov 9, 2021
* Remove constructor without `CodeGenerator` parameter
* Replace `TR::comp()` reach inside each constructor with `CodeGenerator` query
* Add missing `_directlyTargeted` field initializaton to all constructors

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Passing in the CodeGenerator object eliminates the need to fetch the
Compilation object from `TR::comp()`.

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl

0xdaryl commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@0xdaryl 0xdaryl changed the title WIP: Misc. LabelSymbol improvements Misc. LabelSymbol improvements Nov 9, 2021
@0xdaryl

0xdaryl commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

@dsouzai : would you mind reviewing please?

@dsouzai
dsouzai merged commit d648975 into eclipse-omr:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants