Skip to content

Implement vadd and vsub for Short and ByteVectors of size 128 - #6237

Merged
aviansie-ben merged 2 commits into
eclipse-omr:masterfrom
midronij:vAddSub
Nov 16, 2021
Merged

aviansie-ben merged 2 commits into
eclipse-omr:masterfrom
midronij:vAddSub

Conversation

@midronij

@midronij midronij commented Nov 10, 2021 •

Copy link
Copy Markdown
Contributor

Implements vadd and vsub for Short and ByteVectors of size 128

Signed-off-by: midronij <jackie.midroni@ibm.com>
@midronij

midronij commented Nov 10, 2021 •

Copy link
Copy Markdown
Contributor Author

@gita-omr @IBMJimmyk could you review when you get a chance please?

@IBMJimmyk

Copy link
Copy Markdown
Contributor

The changes look good to me.

@0xdaryl

0xdaryl commented Nov 13, 2021

Copy link
Copy Markdown
Contributor

Jenkins build plinux,aix

@aviansie-ben aviansie-ben left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a functional aspect, just one minor style nit.

Comment thread compiler/p/codegen/OMRCodeGenerator.cpp Resolved
Signed-off-by: midronij <jackie.midroni@ibm.com>
@aviansie-ben

Copy link
Copy Markdown
Contributor

Jenkins build plinux,aix

@aviansie-ben
aviansie-ben merged commit f76321a into eclipse-omr:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants