Repository navigation
Remove obsolete overloading of ArrayStoreCHK - #6241
Merged
0xdaryl merged 1 commit intoNov 20, 2021
Merged
Conversation
hzongaro
requested review from
0xdaryl and
a7ehuo
and removed request for
Leonardo2718 and
vijaysun-omr
November 15, 2021 21:21
Contributor
Author
Contributor
Author
Contributor
|
Just one very minor comment on the commit message:
|
A downstream project used overloading of ArrayStoreCHK to allow for checking of whether a null reference was being stored to an array whose component type is one that does not allow for null references. That overloading is no longer used in the downstream project, and the new nonNullableArrayNullStoreCheck non-helper symbol can be used to achieve the same effect. This change removes the potential overloading of ArrayStoreCHK. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
force-pushed
the
vt-drop-ArrayStoreCHK-overloading
branch
from
November 16, 2021 20:43
7478aed to
232e20e
Compare
Contributor
Author
Fixed in commit 232e20e |
Contributor
|
Jenkins build all |
Contributor
|
Jenkins build aix |
Contributor
|
Jenkins build aix Once more... This time with FEELING! |
Contributor
|
Jenkins build aix AIX node timed out during the build. |
0xdaryl
approved these changes
Nov 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A downstream project used overloading of
ArrayStoreCHKto allow for checking of whether a null reference was being stored to an array whose component type is one that does not allow for null references. That overloading is no longer used in the downstream project, and the newnonNullableArrayNullStoreChecknon-helper symbol can be used to achieve the same effect. This change removes the now obsolete potential overloading ofArrayStoreCHK.