Skip to content

Remove obsolete overloading of ArrayStoreCHK - #6241

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
hzongaro:vt-drop-ArrayStoreCHK-overloading
Nov 20, 2021
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
hzongaro:vt-drop-ArrayStoreCHK-overloading

Conversation

@hzongaro

@hzongaro hzongaro commented Nov 15, 2021 •

Copy link
Copy Markdown
Contributor

A downstream project used overloading of ArrayStoreCHK to allow for checking of whether a null reference was being stored to an array whose component type is one that does not allow for null references. That overloading is no longer used in the downstream project, and the new nonNullableArrayNullStoreCheck non-helper symbol can be used to achieve the same effect. This change removes the now obsolete potential overloading of ArrayStoreCHK.

@hzongaro

Copy link
Copy Markdown
Contributor Author

Annabelle @a7ehuo, Daryl @0xdaryl, may I ask you to review?

@hzongaro

Copy link
Copy Markdown
Contributor Author

I should have noted for reference that this change effectively reverts commit ace1744 and part of commit e5dd6f4

@a7ehuo a7ehuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a7ehuo

a7ehuo commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Just one very minor comment on the commit message: nonNullableArrayStoreNullCheck should be nonNullableArrayNullStoreCheck which is what is defined in OMRSymbolReferenceTable.cpp.

nonNullableArrayStoreNullCheck
==>
nonNullableArrayNullStoreCheck

A downstream project used overloading of ArrayStoreCHK to allow for
checking of whether a null reference was being stored to an array whose
component type is one that does not allow for null references.  That
overloading is no longer used in the downstream project, and the new
nonNullableArrayNullStoreCheck non-helper symbol can be used to
achieve the same effect.  This change removes the potential overloading
of ArrayStoreCHK.

Signed-off-by:  Henry Zongaro <zongaro@ca.ibm.com>
@hzongaro
hzongaro force-pushed the vt-drop-ArrayStoreCHK-overloading branch from 7478aed to 232e20e Compare November 16, 2021 20:43
@hzongaro

Copy link
Copy Markdown
Contributor Author

nonNullableArrayStoreNullCheck should be nonNullableArrayNullStoreCheck

Fixed in commit 232e20e

@0xdaryl

0xdaryl commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl 0xdaryl self-assigned this Nov 19, 2021
@0xdaryl

0xdaryl commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Jenkins build aix

@0xdaryl

0xdaryl commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Jenkins build aix

Once more... This time with FEELING!

@0xdaryl

0xdaryl commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Jenkins build aix

AIX node timed out during the build.

@0xdaryl
0xdaryl merged commit 41669e7 into eclipse-omr:master Nov 20, 2021
@hzongaro
hzongaro deleted the vt-drop-ArrayStoreCHK-overloading branch November 22, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants