Repository navigation
Implement vmul for IntVectors, ShortVectors, and ByteVectors of size 128 - #6245
Conversation
|
@gita-omr @IBMJimmyk could you please review when you have a chance? |
f4e8f29 to
371392e
Compare
IBMJimmyk
left a comment
There was a problem hiding this comment.
Also there are a few places with types are listed out of order. I think it makes it easier to follow if they are always in the order of:
Int8, Int16, Int32, Int64, Float, Double
58c44b1 to
681196b
Compare
IBMJimmyk
left a comment
There was a problem hiding this comment.
The new changes look good to me.
aviansie-ben
left a comment
There was a problem hiding this comment.
The evaluator changes LGTM. Please add binary encoder unit tests for the newly enabled instructions.
|
@aviansie-ben, could you please re-review now with the binary encoder tests? |
|
Finished first round of requested changes from Devin, commenting to retain git diff |
|
@jdmpapin requested changed are complete! Feel free to merge if everything looks good |
|
|
|
Not sure why it disappeared, but I just added |
|
Here is the diff between the revision that I reviewed above and the current revision (skipping over the deletion and re-addition of |
|
Code changes look good now. Just need to update the copyright dates in these files:
(I should have checked these earlier for fewer rounds of review...) |
|
Jenkins build plinux,aix |
|
Only building Power because all changes here are specific to the Power code generator |
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
|
Jenkins build plinux,aix |
Signed-off-by: midronij <jackie.midroni@ibm.com>
|
Jenkins build plinux,aix |
This contribution includes the following changes: