Skip to content

Implement vmul for IntVectors, ShortVectors, and ByteVectors of size 128 - #6245

Merged
jdmpapin merged 4 commits into
eclipse-omr:masterfrom
midronij:vmul
Nov 26, 2021
Merged

jdmpapin merged 4 commits into
eclipse-omr:masterfrom
midronij:vmul

Conversation

@midronij

@midronij midronij commented Nov 18, 2021 •

Copy link
Copy Markdown
Contributor

This contribution includes the following changes:

  • The seven instruction sequence previously used for vmul for IntVectors has been replaced with a single vmuluwm instruction
  • vmul for ShortVectors and ByteVectors have each been implemented with multi-instruction sequences, since there is no single PPC assembly insruction that can perform this operation for these vector types
  • Binary encoder unit tests have been added for newly enabled instructions

@midronij

Copy link
Copy Markdown
Contributor Author

@gita-omr @IBMJimmyk could you please review when you have a chance?

@IBMJimmyk IBMJimmyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there are a few places with types are listed out of order. I think it makes it easier to follow if they are always in the order of:
Int8, Int16, Int32, Int64, Float, Double

Comment thread compiler/p/codegen/OMRTreeEvaluator.cpp Resolved
Comment thread compiler/p/codegen/OMRTreeEvaluator.cpp Resolved
Comment thread compiler/p/codegen/OMRTreeEvaluator.cpp Resolved
Comment thread compiler/p/codegen/OMRCodeGenerator.cpp Resolved
Comment thread compiler/p/codegen/OMRCodeGenerator.cpp Resolved
@midronij
midronij force-pushed the vmul branch 2 times, most recently from 58c44b1 to 681196b Compare November 18, 2021 15:32

@IBMJimmyk IBMJimmyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new changes look good to me.

@aviansie-ben aviansie-ben left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The evaluator changes LGTM. Please add binary encoder unit tests for the newly enabled instructions.

@jdmpapin jdmpapin self-assigned this Nov 19, 2021
Comment thread compiler/p/codegen/OMRTreeEvaluator.cpp Resolved
@jdmpapin

Copy link
Copy Markdown
Contributor

@aviansie-ben, could you please re-review now with the binary encoder tests?

@aviansie-ben aviansie-ben left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread compiler/p/codegen/OMRTreeEvaluator.cpp Resolved
Comment thread compiler/p/codegen/OMRCodeGenerator.cpp Resolved
Comment thread compiler/p/codegen/OMRTreeEvaluator.cpp Resolved
@midronij

midronij commented Nov 26, 2021 •

Copy link
Copy Markdown
Contributor Author

Finished first round of requested changes from Devin, commenting to retain git diff

@midronij

Copy link
Copy Markdown
Contributor Author

@jdmpapin requested changed are complete! Feel free to merge if everything looks good

@jdmpapin

Copy link
Copy Markdown
Contributor

vmulInt8Helper has gone missing

@midronij

Copy link
Copy Markdown
Contributor Author

Not sure why it disappeared, but I just added vmulInt8Helper back

@jdmpapin

Copy link
Copy Markdown
Contributor

Here is the diff between the revision that I reviewed above and the current revision (skipping over the deletion and re-addition of vmulInt8Helper()), which shows that the cleanup of the history hasn't introduced any other unintended changes

@jdmpapin

Copy link
Copy Markdown
Contributor

Code changes look good now. Just need to update the copyright dates in these files:

  • compiler/p/codegen/OMRInstOpCode.enum
  • compiler/p/codegen/OMRInstOpCodeProperties.hpp
  • fvtest/compilerunittest/p/BinaryEncoder.cpp

(I should have checked these earlier for fewer rounds of review...)

@jdmpapin

Copy link
Copy Markdown
Contributor

Jenkins build plinux,aix

@jdmpapin

Copy link
Copy Markdown
Contributor

Only building Power because all changes here are specific to the Power code generator

Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
@jdmpapin

Copy link
Copy Markdown
Contributor

Jenkins build plinux,aix

Signed-off-by: midronij <jackie.midroni@ibm.com>
@jdmpapin

Copy link
Copy Markdown
Contributor

Jenkins build plinux,aix

@jdmpapin
jdmpapin merged commit 27dc2f8 into eclipse-omr:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants