Skip to content

Update z/OS compile to use V2R3 - #6250

Merged
0xdaryl merged 2 commits into
eclipse-omr:masterfrom
jdekonin:master
Mar 29, 2022
Merged

0xdaryl merged 2 commits into
eclipse-omr:masterfrom
jdekonin:master

Conversation

@jdekonin

Copy link
Copy Markdown
  • with the z/OS guests being replaced with V2R4 systems the lowest level xlc compiles to that is supported is now V2R3.

Signed-off-by: Joe deKoning joe_dekoning@ca.ibm.com

@jdekonin

Copy link
Copy Markdown
Author

fyi @joransiu @pshipton

@jdekonin

Copy link
Copy Markdown
Author

I am thinking we need to differentiate JDK8 and JDK11 if we have different support levels. JDK8 = V2R1 iirc, whereas JDK11 = V2R3. Do I have this correct?

Something like how OpenJ9 already has it? Example
https://github.com/eclipse-openj9/openj9/blob/07362270e98ac82695a7b7cffbfb7aa43a759814/runtime/compiler/build/toolcfg/zos-xlc/common.mk#L35

@jdekonin

Copy link
Copy Markdown
Author

OpenJ9 overrides OMR settings so that would appear irrelevant to differentiate for JDK8/11. Do we want to match the system version of V2R4 for OMR_ZOS_COMPILE_TARGET and OMR_ZOS_LINK_COMPAT?

OMR_ZOS_COMPILE_ARCHITECTURE...@joransiu / @r30shah I am thinking this is linked to the version of xlc or system version??. I see openj9 has this value defaulting to 10 with V2R3? What where should this value be?
eclipse-openj9/openj9@23a6a4f

@pshipton

pshipton commented Nov 23, 2021 •

Copy link
Copy Markdown
Contributor

@@ -114,9 +114,9 @@ elseif(OMR_OS_LINUX)
)
elseif(OMR_OS_ZOS)
set(OMR_ZOS_COMPILE_ARCHITECTURE "7" CACHE STRING "z/OS compile machine architecture")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go ahead with this change, this should change to "10" to match the V2R3 settings.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread configure Outdated
@@ -1747,11 +1747,11 @@ Some influential environment variables:
OMR_ZOS_COMPILE_ARCHITECTURE
The z/OS compile machine architecture. (Default: 7)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 10.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread configure Outdated
@@ -2880,9 +2880,9 @@ OMR_PRODUCT_NAME=${OMR_PRODUCT_NAME:-"OMR"}
OMR_PRODUCT_VERSION=${OMR_PRODUCT_VERSION:-"0.1"}

OMR_ZOS_COMPILE_ARCHITECTURE=${OMR_ZOS_COMPILE_ARCHITECTURE:-"7"}

@pshipton pshipton Nov 23, 2021 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 10

Comment thread configure.ac Outdated
@@ -69,11 +69,11 @@ AC_ARG_VAR([OMR_PRODUCT_DESCRIPTION],
AC_ARG_VAR([OMR_ZOS_COMPILE_ARCHITECTURE],
[The z/OS compile machine architecture. (Default: 7)])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 10

Comment thread configure.ac Resolved
@r30shah

r30shah commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

OMR_ZOS_COMPILE_ARCHITECTURE...@joransiu / @r30shah I am thinking this is linked to the version of xlc or system version??.

@jdekonin , Java 11 on z/OS supports V2R3 and later on zEC12, that is why we have OMR_ZOS_COMPILE_ARCHITECTURE set to 10 (I believe this converts to the ARCH options supplied to xLC.

@pshipton

Copy link
Copy Markdown
Contributor

@joransiu

Copy link
Copy Markdown
Contributor

Java 11 on z/OS supports V2R3 and later on zEC12

Java 11 on z/OS actually pre-reqs V2R4, though we are still compiling on V2R3 internally. That said, as noted above already, Java 8 will still need to be built with the original V1R13 compatibility.

@jdekonin

Copy link
Copy Markdown
Author

The reason I did this change is because on the new V2R4 guests the use of V1R13 produced warnings like I have detailed below.

CCN0835(I) TARGET suboption "zOSV1R13" is discontinued. Unexpected behavior might occur if an out-of-support TARGET level is specified. Use a TARGET level of "zOSV2R2", or later instead.

OMR doesn't appear to have a notion of building for a specific JDK release, so it would appear the options are

  1. add release specific functionality into OMR
  2. go with minimum o/s in support (V2R3 atm)
  3. other??

I'll test with what the PR currently has to see what the the breakage is like for Java 8 builds.

@pshipton

Copy link
Copy Markdown
Contributor

We can modify OpenJ9 if necessary to specify the correct values when building Java 8, that just needs to be done first.

@jdekonin

Copy link
Copy Markdown
Author

It would appear from my internal testing that this change is in fact completely overwritten by openj9.

Being that our original 2 z/OS guests are on V2R2, this will need to wait until 1 or both new systems are online.

@jdekonin

Copy link
Copy Markdown
Author

I had to push a new change for the automated build. The user id and home directory is different on the new systems, so this change should make that more flexible for any future machine adds that are not identical.

@jdekonin
jdekonin marked this pull request as ready for review November 25, 2021 14:04
@jdekonin

Copy link
Copy Markdown
Author

Jenkins build zos_390-64

@AdamBrousseau

Copy link
Copy Markdown
Contributor

Jenkins build zos

@AdamBrousseau

Copy link
Copy Markdown
Contributor

Jenkins build all

@jdekonin

Copy link
Copy Markdown
Author

Jenkins build zos_390-64

1 similar comment
@jdekonin

Copy link
Copy Markdown
Author

Jenkins build zos_390-64

@jdekonin

Copy link
Copy Markdown
Author

Seems PR jobs don't use the PR code change in the job when it comes to the build scripts. LIBPATH=/openzdk/jenkins/workspace/Build/build... is incorrect in the job and as such fails to find/load the built test libraries. You can see in the env var output HOME=/u/user1, so I don't see why the change I have to buildenv/jenkins/jobs/builds/Build-zos_390-64 in this PR wouldn't work.

@jdekonin

Copy link
Copy Markdown
Author

Still needs to hold until the 2nd z/OS guest from Marist is availlable. eta today/tomorrow I hope

@jdekonin

Copy link
Copy Markdown
Author

Jenkins build all

Comment thread configure.ac Resolved
Comment thread configure Resolved
@jdekonin
jdekonin force-pushed the master branch 3 times, most recently from 6e54924 to 021926f Compare March 7, 2022 17:37
pshipton added a commit to pshipton/openj9 that referenced this pull request Mar 16, 2022
Issue eclipse-omr/omr#6250 (comment)

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@jdekonin

Copy link
Copy Markdown
Author

Performed a rebase and new round of builds to verify. The older systems have been requested to be returned so unless there are additional changes needed this requires review/merge. Discussed with @pshipton & @AdamBrousseau via slack and there should be no dependency or problems with OpenJ9.

@jdekonin

Copy link
Copy Markdown
Author

Jenkins build zos

2 similar comments
@jdekonin

Copy link
Copy Markdown
Author

Jenkins build zos

@AdamBrousseau

Copy link
Copy Markdown
Contributor

Jenkins build zos

Joe deKoning added 2 commits March 29, 2022 14:24
* [skip ci]
* modify hardcoded user home to variable

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
@AdamBrousseau

Copy link
Copy Markdown
Contributor

Jenkins build all

@jdekonin

Copy link
Copy Markdown
Author

z/OS job in the build all was directed to ZISVJD09 and passed as per below url to job. I am going to kick off another one to validate ZISVJD10.
https://ci.eclipse.org/omr/job/PullRequest-zos_390-64/3507/console

@jdekonin

Copy link
Copy Markdown
Author

Jenkins build zos

@0xdaryl

0xdaryl commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

@joransiu : can you please formally approve this if you think it is ready to merge?

@joransiu joransiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xdaryl 0xdaryl self-assigned this Mar 29, 2022
@0xdaryl
0xdaryl merged commit 72289b9 into eclipse-omr:master Mar 29, 2022
pshipton added a commit to pshipton/openj9 that referenced this pull request Feb 15, 2023
They need to be explicitly set for Java 8 because the defaults were
changed by eclipse-omr/omr#6250

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants