Skip to content

Prevent OSR transitions from failed guards - #6255

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
nbhuiyan:osr-fix
Nov 25, 2021
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
nbhuiyan:osr-fix

Conversation

@nbhuiyan

Copy link
Copy Markdown
Contributor

For inlined callee methods that we skip creating HCR guards for,
setting createdHCRGuard to false prevents creating an OSR
transition point to be taken in cases such as a failed
TR_ProfiledGuard.

Issue: eclipse-openj9/openj9#13162

Signed-off-by: Nazim Bhuiyan nubhuiyan@ibm.com

For inlined callee methods that we skip creating HCR guards for,
setting createdHCRGuard to false prevents creating an OSR
transition point to be taken in cases such as a failed
TR_ProfiledGuard.

Signed-off-by: Nazim Bhuiyan <nubhuiyan@ibm.com>
@vijaysun-omr

Copy link
Copy Markdown
Contributor

jenkins build all

@vijaysun-omr

Copy link
Copy Markdown
Contributor

@0xdaryl please review as well

@0xdaryl 0xdaryl self-assigned this Nov 25, 2021
@0xdaryl

0xdaryl commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Further downstream testing with OpenJ9 JDK17 completed successfully.

@0xdaryl
0xdaryl merged commit e1762a2 into eclipse-omr:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants