Skip to content

Remove misc. dead x87 code - #6378

Merged
dsouzai merged 5 commits into
eclipse-omr:masterfrom
0xdaryl:noassignfpregs
Mar 15, 2022
Merged

dsouzai merged 5 commits into
eclipse-omr:masterfrom
0xdaryl:noassignfpregs

Conversation

@0xdaryl

@0xdaryl 0xdaryl commented Mar 2, 2022

Copy link
Copy Markdown
Contributor
  • Remove x87 assignFPRegisters() from RegisterDependency
  • Remove x87 AllFPRegisters RegisterDependency special register
  • Remove x87 X86FPRemainderRegRegInstruction class
  • Remove x87 X86FPArithmeticRegRegInstruction class
  • Remove x87 numReferencedFPRegisters()

@0xdaryl

0xdaryl commented Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build xlinux,osx,win,x32linux

@0xdaryl
0xdaryl marked this pull request as draft March 2, 2022 18:24
@0xdaryl

0xdaryl commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build xlinux,osx,win,x32linux

@0xdaryl
0xdaryl marked this pull request as ready for review March 9, 2022 01:13
@0xdaryl

0xdaryl commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

@BradleyWood : would you mind reviewing this PR please when you have a moment?

@BradleyWood

Copy link
Copy Markdown
Contributor

LGTM

@0xdaryl

0xdaryl commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

@dsouzai : would you mind merging this PR please?

0xdaryl added 5 commits March 14, 2022 10:55
x87 has been deprecated and this logic no longer applies.

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Assume it returns 0 and fold code accordingly.

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl

0xdaryl commented Mar 14, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build xlinux,osx,win,x32linux

@dsouzai
dsouzai merged commit cd8a2e0 into eclipse-omr:master Mar 15, 2022
@dsouzai dsouzai self-assigned this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants