Repository navigation
Remove misc. dead x87 code - #6378
Merged
Merged
Conversation
0xdaryl
commented
Mar 2, 2022
Contributor
- Remove x87 assignFPRegisters() from RegisterDependency
- Remove x87 AllFPRegisters RegisterDependency special register
- Remove x87 X86FPRemainderRegRegInstruction class
- Remove x87 X86FPArithmeticRegRegInstruction class
- Remove x87 numReferencedFPRegisters()
Contributor
Author
|
Jenkins build xlinux,osx,win,x32linux |
0xdaryl
marked this pull request as draft
March 2, 2022 18:24
Contributor
Author
|
Jenkins build xlinux,osx,win,x32linux |
0xdaryl
marked this pull request as ready for review
March 9, 2022 01:13
Contributor
Author
|
@BradleyWood : would you mind reviewing this PR please when you have a moment? |
Contributor
|
LGTM |
Contributor
Author
|
@dsouzai : would you mind merging this PR please? |
x87 has been deprecated and this logic no longer applies. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Assume it returns 0 and fold code accordingly. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Contributor
Author
|
Jenkins build xlinux,osx,win,x32linux |
dsouzai
approved these changes
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.