Repository navigation
SATB TLH Batch Mark - #6388
SATB TLH Batch Mark#6388
Conversation
|
@amicic @dmitripivkine please review. This is TLH post-batch mark, ideally we're looking to do "pre-batch". Will follow up these changes with converting to pre-batch style. I'm more comfortable doing the changes incrementally as I've done all testing with this style. |
- Implementation to seal TLH with java.lang.Object. (Relates to: eclipse-omr/omr#6388) - Inline allocation path to account for SATB allocation (pre write barrier might scan newly alloced obj object - always zero it with SATB) Signed-off-by: Salman Rana <salman.rana@ibm.com>
be5bf26 to
8282b7b
Compare
|
looks good now. let's just do a round of sanity testing |
|
👍 Running a set of Personal Builds |
f8866f3 to
ce3150c
Compare
|
Latest pushes are just squashing commits + rebase |
|
Things look good, no issues while testing |
e61257e to
7feeb8a
Compare
amicic
left a comment
There was a problem hiding this comment.
Looks good, but let's wait for @dmitripivkine's another look before requesting a merge.
|
@0xdaryl ready to be merged, could you please have a look |
|
Minor readability issues in the commit message:
... preserve the invariant ... (there's a word missing in that sentence, not sure if "the" is the right one)
However, doing so is non-trivial: we must know...
... can't be marked, and this is ...
However, we must guarantee... (there's a word missing in that sentence, not sure if "we" is the right one)
... introduce a mechanism ...
If so, part of TOP of TLH is hidden. Once the TLH ... |
|
👍 fixed |
|
Sorry for being pedantic, but you didn't do the 2nd or the last suggested wording. Was that intentional? |
Objects allocated while CM (SATB) is active must be marked to preserve the invariant required to guarantee correctness. Instead of marking each obj individually, we can mark on the TLH level. However, doing so is non-trivial: we must know the start of the last object to mark the proper range of the TLH. That is, arbitrary bits at the end of the TLH can't be marked, and this is problematic for sweep. To get around this issue we seal the TLH with a bogus/dummy obj at the end of the TLH. With this, we know the precise addr to mark up to. However, we must guarantee that we have at least min obj size available in the TLH. These changes introduce a mechanism for the collector to reserve bytes in a TLH. Whenever the TLH is refreshed, it queries the collector to determine if it should reserve space for it. If so, part of TOP of the TLH is hidden. Once the TLH is about to be flushed/cleared, we restore the the TLH Top and notify the collector. Signed-off-by: Salman Rana <salman.rana@ibm.com>
|
No worries, it should be fixed now. I didn't catch all the suggested changes in those 2, I should of slowed down 😬 |
|
Jenkins build all |
Objects allocated while CM (SATB) is active must be marked to preserve
the invariant required to guarantee correctness.
Instead of marking each obj individually, we can mark on the TLH level.
However, doing so is non-trivial: we must know the start of the last
object to mark the proper range of the TLH. That is, arbitrary bits at
the end of the TLH can't be marked, and this is problematic for sweep.
To get around this issue we seal the TLH with a bogus/dummy obj at the
end of the TLH. With this, we know the precise addr to mark up to.
However, we must guarantee that we have at least min obj size available
in the TLH.
These changes introduce a mechanism for the collector to reserve bytes
in a TLH. Whenever the TLH is refreshed, it queries the collector to
determine if it should reserve space for it. If so, part of TOP of the
TLH is hidden. Once the TLH is about to be flushed/cleared, we restore
the the TLH Top and notify the collector.
Signed-off-by: Salman Rana salman.rana@ibm.com