Skip to content

Add UseOnlyAlias for arraycmp when populating potential deps - #6415

Merged
vijaysun-omr merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:fix-liveRangeReduction-arraycmp
Mar 23, 2022
Merged

vijaysun-omr merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:fix-liveRangeReduction-arraycmp

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Mar 16, 2022

Copy link
Copy Markdown
Contributor

If there are store nodes before arraycmp, arraycmp can share
base addresses with them. UseonlyAliases needs to be set up to
prevent the store nodes from being moved beyond arraycmp.

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

@a7ehuo
a7ehuo requested a review from vijaysun-omr as a code owner March 16, 2022 01:05
@a7ehuo
a7ehuo force-pushed the fix-liveRangeReduction-arraycmp branch from 9de1947 to 0e46b0d Compare March 16, 2022 01:18
@a7ehuo a7ehuo changed the title WIP: Add UseOnlyAlias for arraycmp when populating potential deps Add UseOnlyAlias for arraycmp when populating potential deps Mar 16, 2022
@a7ehuo

a7ehuo commented Mar 16, 2022

Copy link
Copy Markdown
Contributor Author

@vijaysun-omr @hzongaro May I ask you to review this change? Thanks you!

@a7ehuo
a7ehuo requested a review from hzongaro March 16, 2022 14:47
@a7ehuo
a7ehuo force-pushed the fix-liveRangeReduction-arraycmp branch from 0e46b0d to 6f696af Compare March 21, 2022 14:38

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. Thanks!

@a7ehuo

a7ehuo commented Mar 21, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@hzongaro

Copy link
Copy Markdown
Contributor

@a7ehuo Annabelle, now that the change has been generalized to apply to any operation that has use-only aliases, not only arraycmp, may I suggest that you update the commit message?

UseonlyAliases needs to be set up to prevent the store nodes
from being moved beyond the nodes that access the same address.

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo force-pushed the fix-liveRangeReduction-arraycmp branch from 6f696af to 4229f30 Compare March 22, 2022 15:25
@a7ehuo

a7ehuo commented Mar 22, 2022

Copy link
Copy Markdown
Contributor Author

may I suggest that you update the commit message?

@hzongaro updated in 4229f30

@a7ehuo

a7ehuo commented Mar 22, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@a7ehuo

a7ehuo commented Mar 22, 2022

Copy link
Copy Markdown
Contributor Author

zos_390-64 build failure is infrastructural.
x86-64 Windows check completed successfully. Not sure why the status still shows it's running after almost 4hrs.

@a7ehuo

a7ehuo commented Mar 22, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build win

@a7ehuo

a7ehuo commented Mar 22, 2022

Copy link
Copy Markdown
Contributor Author

The stuck eclipse.omr (x86-64 Windows) is automatically triggered by a commit push, not by the build command. @vijaysun-omr I wonder if its status could be ignored since the pipeline shows 100% tests passed.

x86-64 Windows

[View raw log](https://dev.azure.com/eclipse-omr/ea4519db-b27e-4d19-a971-f01491f803e3/_apis/build/builds/5152/logs/54)

Agent: Azure Pipelines 7
Started: Today at 11:27 AM
Duration: 22m 7s

Job preparation parameters
7 queue time variables used
[100% tests](https://dev.azure.com/eclipse-omr/omr/_build/results?buildId=5152&view=ms.vss-test-web.build-test-results-tab) passed

@vijaysun-omr

Copy link
Copy Markdown
Contributor

This is a common code change that has now been approved. It passes on all platforms except zos (infra issues) and windows (see #6415 (comment)). Merging on this basis.

@vijaysun-omr
vijaysun-omr merged commit 3e1f679 into eclipse-omr:master Mar 23, 2022
@a7ehuo
a7ehuo deleted the fix-liveRangeReduction-arraycmp branch April 28, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants