Repository navigation
Restrict VP checkcast tenured alignment logic to loadaddr - #6437
Merged
0xdaryl merged 1 commit intoMar 28, 2022
Merged
Conversation
If the type child of the checkcast node is a static load (rather than loadaddr), then the static address will be incorrectly interpreted as a class pointer. This change is just a precaution. It's unlikely that it will be possible for a static load to appear in this position for some time, even for a checkcast node whose cast type is dynamic.
Contributor
|
Jenkins build all |
Contributor
|
zOS failure is infrastructural. |
0xdaryl
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the type child of the
checkcastnode is a static load (rather thanloadaddr), then the static address will be incorrectly interpreted as a class pointer.This change is just a precaution. It's unlikely that it will be possible for a static load to appear in this position for some time, even for a
checkcastnode whose cast type is dynamic.