Repository navigation
Rename memory TR::Region fields in Structure to improve code clarity - #6440
Merged
Merged
Conversation
0xdaryl
commented
Mar 28, 2022
| TR_StackMemory trStackMemory() { return trMemory(); } | ||
| TR::Region &structureRegion() { return _structureRegion; } | ||
| TR::Region &structureMemoryRegion() { return _structureMemoryRegion; } | ||
| TR::Region &structureRegion() { return _structureMemoryRegion; } |
Contributor
Author
There was a problem hiding this comment.
Note to reviewers: this function must stick around until its use can be eliminated in downstream projects. I will be taking care of that shortly.
Contributor
Author
|
Jenkins build all |
Contributor
Author
|
Jenkins build zos |
0xdaryl
marked this pull request as ready for review
March 31, 2022 14:45
0xdaryl
requested review from
Leonardo2718,
mstoodle and
vijaysun-omr
as code owners
March 31, 2022 14:45
dsouzai
reviewed
Mar 31, 2022
…arity Signed-off-by: Daryl Maier <maier@ca.ibm.com>
…` to improve clarity Signed-off-by: Daryl Maier <maier@ca.ibm.com>
…ove clarity Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
0xdaryl
force-pushed
the
structureregion
branch
from
March 31, 2022 17:55
b80498f to
7a9ad44
Compare
Contributor
Author
|
Jenkins build all |
dsouzai
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The term 'region' is overloaded when building method structure for both a structural component and for the allocator to satisfy memory requests.
In these contexts, rename fields that refer to
TR::Regions to make it clear that they are memory regions.