Skip to content

Rename memory TR::Region fields in Structure to improve code clarity - #6440

Merged
dsouzai merged 5 commits into
eclipse-omr:masterfrom
0xdaryl:structureregion
Apr 4, 2022
Merged

dsouzai merged 5 commits into
eclipse-omr:masterfrom
0xdaryl:structureregion

Conversation

@0xdaryl

@0xdaryl 0xdaryl commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

The term 'region' is overloaded when building method structure for both a structural component and for the allocator to satisfy memory requests.

In these contexts, rename fields that refer to TR::Regions to make it clear that they are memory regions.

Comment thread compiler/infra/OMRCfg.hpp
TR_StackMemory trStackMemory() { return trMemory(); }
TR::Region &structureRegion() { return _structureRegion; }
TR::Region &structureMemoryRegion() { return _structureMemoryRegion; }
TR::Region &structureRegion() { return _structureMemoryRegion; }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: this function must stick around until its use can be eliminated in downstream projects. I will be taking care of that shortly.

@0xdaryl

0xdaryl commented Mar 28, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@0xdaryl

0xdaryl commented Mar 31, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build zos

@0xdaryl
0xdaryl marked this pull request as ready for review March 31, 2022 14:45
@dsouzai dsouzai self-assigned this Mar 31, 2022
0xdaryl added 5 commits March 31, 2022 13:49
…arity

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
…` to improve clarity

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
…ove clarity

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl

0xdaryl commented Mar 31, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@dsouzai
dsouzai merged commit f65786a into eclipse-omr:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants