Skip to content

Remove long disabled TR_ASSERTC macros - #6442

Merged
dsouzai merged 1 commit into
eclipse-omr:masterfrom
0xdaryl:noassertc
Mar 28, 2022
Merged

dsouzai merged 1 commit into
eclipse-omr:masterfrom
0xdaryl:noassertc

Conversation

@0xdaryl

@0xdaryl 0xdaryl commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

The preprocessor macro does not even exist any longer.

Signed-off-by: Daryl Maier maier@ca.ibm.com

The preprocessor macro does not even exist any longer.

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl

0xdaryl commented Mar 28, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@0xdaryl

0xdaryl commented Mar 28, 2022

Copy link
Copy Markdown
Contributor Author

@dsouzai : another small cleanup item, deletions only. Would you mind reviewing please?


cg->decReferenceCount(elemsExpr);
//TR_ASSERTC( elemsExpr->getSize() <=4,comp, "If this is not true we should not be truncating");
//someone should investigate why this assertion is not being hit

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@dsouzai dsouzai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsouzai

dsouzai commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

jenkins build win

@dsouzai dsouzai self-assigned this Mar 28, 2022
@dsouzai
dsouzai merged commit 48f7acb into eclipse-omr:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants