Repository navigation
Fix for newly allocated RS puddle delayed initialization - #6444
Merged
Merged
Conversation
Contributor
Author
|
@dmitripivkine please, review |
This prevents a delayed initialization of RememberedSet puddle, on POWER weak memory model, that may occur when the puddle is exposed to other threads/CPUs before the initialization has completed. In turn the delayed initialization could wipe out valid remembered objects added by other racing threads. The fix introduces a low-level writeBarrier that will enforce the initializaton completion, before the puddle is exposed to other threads. Signed-off-by: Aleksandar Micic <amicic@ca.ibm.com>
amicic
force-pushed
the
puddle_delayed_init_fix
branch
from
March 29, 2022 16:09
546a3b5 to
f8653d6
Compare
dmitripivkine
approved these changes
Mar 29, 2022
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a delayed initialization of RememberedSet puddle, on POWER
weak memory model, that may occur when the puddle is exposed to other
threads/CPUs before the initialization has completed.
In turn the delayed initialization could wipe out valid remembered
object added by other racing threads.
The fix introduces a low-level writeBarrier that will enforce the
initializaton completion, before the puddle is exposed to other threads.
Signed-off-by: Aleksandar Micic amicic@ca.ibm.com