Skip to content

Fix for newly allocated RS puddle delayed initialization - #6444

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
amicic:puddle_delayed_init_fix
Mar 29, 2022
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
amicic:puddle_delayed_init_fix

Conversation

@amicic

@amicic amicic commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

This prevents a delayed initialization of RememberedSet puddle, on POWER
weak memory model, that may occur when the puddle is exposed to other
threads/CPUs before the initialization has completed.
In turn the delayed initialization could wipe out valid remembered
object added by other racing threads.

The fix introduces a low-level writeBarrier that will enforce the
initializaton completion, before the puddle is exposed to other threads.

Signed-off-by: Aleksandar Micic amicic@ca.ibm.com

@amicic

amicic commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

@dmitripivkine please, review

This prevents a delayed initialization of RememberedSet puddle, on POWER
weak memory model, that may occur when the puddle is exposed to other
threads/CPUs before the initialization has completed.
In turn the delayed initialization could wipe out valid remembered
objects added by other racing threads.

The fix introduces a low-level writeBarrier that will enforce the
initializaton completion, before the puddle is exposed to other threads.

Signed-off-by: Aleksandar Micic <amicic@ca.ibm.com>
@amicic
amicic force-pushed the puddle_delayed_init_fix branch from 546a3b5 to f8653d6 Compare March 29, 2022 16:09
@0xdaryl

0xdaryl commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

Jenkins build all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants