Repository navigation
Implement vectorized absolute value and square root for all applicable vector types on PPC - #6489
Conversation
|
@gita-omr @IBMJimmyk @aviansie-ben could you please review when you have a chance? |
|
I think this PR does not depend on eclipse-openj9/openj9#14949. If you agree, please remove the Depend comment in the description and this will simplify the merge process. |
|
Jenkins build all |
|
@midronij do you think linux_ppc-64_le_gcc failure is unrelated? |
It looks like an issue in the testing infrastructure. |
|
@gita-omr I believe so. The error is occurring in a test case that I didn't modify, and I can't reproduce it locally |
|
Jenkins build plinux |
2841f8e to
d5d416c
Compare
|
@midronij : please see PPC Linux CI failure. |
|
Jenkins build plinux @0xdaryl Its definitely not related to this PR. |
|
Jenkins build plinux |
|
I think the Power Linux failure that has been reproduced 4 times and only while testing this PR should be investigated before proceeding. |
9f17a81 to
82d4f4c
Compare
|
@gita-omr merge conflicts have been resolved! |
|
Jenkins build plinux |
|
@0xdaryl I've taken a look at the PPC failure that was occurring before, but I was unable to reproduce the error in any test environment. Additionally, it seemed to be occurring during a test that I didn't touch, and the most recent run of the CI build(done just now) passed. Can we proceed, or is further investigation needed? |
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
…structions Signed-off-by: midronij <jackie.midroni@ibm.com>
@knn-k fyi |
| if (et == TR::Float || et == TR::Double) | ||
| return true; | ||
| else | ||
| return false; |
There was a problem hiding this comment.
return (et == TR::Float || et == TR::Double); would be simpler for these lines.
I think it can be done in a separate PR.
|
Jenkins build all |
|
Jenkins build zos_390-64 |
|
No failure on plinux today. |
This contribution includes the following changes: