Repository navigation
Update omrsysinfo_cgroup_subsystem_iterator functions for cgroup v2 - #6494
Conversation
|
@babsingh iterator for v2 memory subsystem is done and working. Can you take an early look? |
yes, I will do one by the end of day. |
e02dc67 to
99958d9
Compare
fada4a0 to
85e22f9
Compare
85e22f9 to
7b50477
Compare
e904299 to
3bb6769
Compare
There was a problem hiding this comment.
For verification, can you provide the Cgroup Information Section from a javacore for cgroup v1 and v2?
Examples in https://blog.openj9.org/2019/04/22/cgroup-metrics-now-available-in-javacore/.
d994db6 to
cb26705
Compare
Cgroup v1Host Container no limits Container with limits Cgroup v2Host Container no limits Container with limits |
|
re #6494 (comment): For |
|
Differences in v2 hierarchy. In v2 if a subsystem is not in cgroup.controllers it means the subsystem is not active / limits are not set for that cgroup |
|
OSX failures: https://github.com/eclipse/omr/pull/6494/checks?check_run_id=6395271683 These failures are related to the socket library, and probably caused due to network issues. |
|
jenkins build all |
|
Compilation error: |
|
jenkins build all |
|
jenkins build all |
|
@EricYangIBM OSX failures consistently happen. Can you confirm that the OSX failures reported in #6494 (comment) are not occurring due to this PR? |
fd0f8c5 to
4e84385
Compare
|
Rebasing didn't change anything but reverting the commit stopped the failures. All of the commit's changes are ifdefd for linux only so I don't know how this PR could cause mac failures |
|
Seems like the most recent builds passed |
|
jenkins build all |
|
Restarting the zOS job since it timed out in finding a node. |
|
jenkins build zos |
|
All zos nodes are offline |
@jdekonin @AdamBrousseau Are the zOS machines strategically turned off? or are we experiencing an outage? Is there a timeline when they will be online? |
|
If there was an outage I wasn't advised or maybe I missed the email?? It would appear that both are online now though. |
|
jenkins build zos |
dsouzai
left a comment
There was a problem hiding this comment.
Overall looks fine; just had a few questions.
4e84385 to
110b845
Compare
Update cgroup iterator functions to retrieve metrics from cgroup v2 files. Issue: eclipse-omr#1281 Signed-off-by: Eric Yang <eric.yang@ibm.com>
110b845 to
2718485
Compare
|
jenkins build all |
|
Tests have passed. |
|
Yes, all that remains after this is related to testing (both v1 and v2) |
|
Great work! Thanks! |
Update cgroup iterator functions to retrieve metrics from cgroup v2
files.
Issue: #1281
Signed-off-by: Eric Yang eric.yang@ibm.com