Repository navigation
Enable Vectorization for supported ops on Z - #6517
Merged
Merged
Conversation
Contributor
Author
|
@joransiu / @gita-omr Can I please get a review on these changes? EDIT: I forgot to mention, we should target these changes to be in 0.33 release. |
Contributor
Author
|
Thanks a lot @joransiu for catching the incorrect variable check in the switch case which I missed while merging my change with updated changes from Gita, Changed it in https://github.com/eclipse/omr/compare/d343cdc3efa2c92f438ac9716de80125eb2eb121..830a971ddc30b106543f89e094b8e15fdd99e246 |
Contributor
Author
dsouzai
reviewed
May 17, 2022
Contributor
|
LGTM. But I agree with @dsouzai that it would be good to add "else" case for vxor/vor/vand. |
This commit enables vectorization of following operations in Vector API for different species. 1. Vector Load and Store for all species. 2. Binary Operations 1. Add/Subtraction : Enabled for all species 2. Multiplication : Enabled for all species except Long 3. Division : Enabled for Float and Doubles only 4. AND/OR/XOR : Enables for all integral types 3. NEG operation for all species 4. Broadcast operation for all species Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
On X and Z right now to get the vectorAPIExpansion to vectorize or scalarize the operation, we need to disable OSRGuard merging. Change in this commit will allow developers on Z and X to test vector API expansion by disabling merging of OSR guards using environment variable. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
dsouzai
approved these changes
May 18, 2022
Contributor
|
jenkins build all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables vectorization of following operations in Vector API
for different species.
Signed-off-by: Rahil Shah rahil@ca.ibm.com