Skip to content

Enable Vectorization for supported ops on Z - #6517

Merged
dsouzai merged 2 commits into
eclipse-omr:masterfrom
r30shah:0.33VectorAPIPR
May 18, 2022
Merged

dsouzai merged 2 commits into
eclipse-omr:masterfrom
r30shah:0.33VectorAPIPR

Conversation

@r30shah

@r30shah r30shah commented May 16, 2022

Copy link
Copy Markdown
Contributor

This commit enables vectorization of following operations in Vector API
for different species.

  1. Vector Load and Store for all species.
  2. Binary Operations
    1. Add/Subtraction : Enabled for all species
    2. Multiplication : Enabled for all species except Long
    3. Division : Enabled for Float and Doubles only
    4. AND/OR/XOR : Enables for all integral types
  3. NEG operation for all species
  4. Broadcast operation for all species

Signed-off-by: Rahil Shah rahil@ca.ibm.com

@r30shah
r30shah marked this pull request as ready for review May 17, 2022 12:48
@r30shah

r30shah commented May 17, 2022 •

Copy link
Copy Markdown
Contributor Author

@joransiu / @gita-omr Can I please get a review on these changes?
In addition to enable the vectorization for all supported species, this PR introduces an environment variable to disable OSR merging guards which we need r.n to enable Vector API Expansion.

EDIT: I forgot to mention, we should target these changes to be in 0.33 release.

@r30shah
r30shah force-pushed the 0.33VectorAPIPR branch from d343cdc to 830a971 Compare May 17, 2022 18:07
@r30shah

r30shah commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

Thanks a lot @joransiu for catching the incorrect variable check in the switch case which I missed while merging my change with updated changes from Gita, Changed it in https://github.com/eclipse/omr/compare/d343cdc3efa2c92f438ac9716de80125eb2eb121..830a971ddc30b106543f89e094b8e15fdd99e246

@joransiu joransiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r30shah

r30shah commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

@jdmpapin / @dsouzai Can I request either of you to launch test / merge these changes? We are targeting set of operations in this PR to vectorized on Z in 0.33 release (Given that split is this Friday)

Comment thread compiler/z/codegen/OMRCodeGenerator.cpp Resolved
@gita-omr

Copy link
Copy Markdown
Contributor

LGTM. But I agree with @dsouzai that it would be good to add "else" case for vxor/vor/vand.

@dsouzai dsouzai self-assigned this May 17, 2022
r30shah added 2 commits May 18, 2022 13:40
This commit enables vectorization of following operations in Vector API
for different species.

1. Vector Load and Store for all species.
2. Binary Operations
   1. Add/Subtraction : Enabled for all species
   2. Multiplication : Enabled for all species except Long
   3. Division : Enabled for Float and Doubles only
   4. AND/OR/XOR : Enables for all integral types
3. NEG operation for all species
4. Broadcast operation for all species

Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
On X and Z right now to get the vectorAPIExpansion to vectorize or
scalarize the operation, we need to disable OSRGuard merging. Change in
this commit will allow developers on Z and X to test vector API
expansion by disabling merging of OSR guards using environment variable.

Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
@r30shah
r30shah force-pushed the 0.33VectorAPIPR branch from 830a971 to 9f9f9e5 Compare May 18, 2022 08:10
@dsouzai

dsouzai commented May 18, 2022

Copy link
Copy Markdown
Contributor

jenkins build all

@dsouzai
dsouzai merged commit dfaa4a2 into eclipse-omr:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants