Skip to content

RISC-V: add variant of instruction encoding utilities taking RegNum - #6578

Merged
0xdaryl merged 2 commits into
eclipse-omr:masterfrom
janvrany:pr/riscv-refactor-instruction-encoding-helpers
Feb 1, 2023
Merged

0xdaryl merged 2 commits into
eclipse-omr:masterfrom
janvrany:pr/riscv-refactor-instruction-encoding-helpers

Conversation

@janvrany

Copy link
Copy Markdown
Contributor

These variants are useful when generating "hand-written" code such as snippets,
trampolines and thunks.

@janvrany
janvrany force-pushed the pr/riscv-refactor-instruction-encoding-helpers branch from 2bab20b to e6015b8 Compare June 20, 2022 12:44
@janvrany

Copy link
Copy Markdown
Contributor Author

jenkins build riscv

@janvrany
janvrany force-pushed the pr/riscv-refactor-instruction-encoding-helpers branch from e6015b8 to a07272a Compare June 20, 2022 20:15
@janvrany
janvrany force-pushed the pr/riscv-refactor-instruction-encoding-helpers branch 2 times, most recently from b214a2f to d00ecac Compare November 10, 2022 14:28
@janvrany

Copy link
Copy Markdown
Contributor Author

jenkins build riscv

@janvrany

Copy link
Copy Markdown
Contributor Author

@0xdaryl , @mstoodle : may I kindly ask for review?

@0xdaryl 0xdaryl self-assigned this Feb 1, 2023

@0xdaryl 0xdaryl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update copyrights to 2023.

This is to allow other code (such as snippets, trampoline code and so on)
to use them to encode instructions. In a future, more utilities may be
added.
These variants are useful when generating "hand-written" code such as snippets, trampolines and thunks.
@janvrany
janvrany force-pushed the pr/riscv-refactor-instruction-encoding-helpers branch from d00ecac to 3a6b926 Compare February 1, 2023 15:37
@janvrany

janvrany commented Feb 1, 2023

Copy link
Copy Markdown
Contributor Author

jenkins build riscv

@janvrany

janvrany commented Feb 1, 2023

Copy link
Copy Markdown
Contributor Author

New version should have copyright fixed as well as newline.
As for the failures, they seem to me unrelated - some port tests fail.

@0xdaryl

0xdaryl commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

This is a RISC-V specific change. None of the other CI failures apply to this PR. Merging.

@0xdaryl
0xdaryl merged commit 00b89d6 into eclipse-omr:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants