Skip to content

Add option to skip ilgen optimizations - #6795

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
kevindean12:skip-ilgenopts
Nov 30, 2022
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
kevindean12:skip-ilgenopts

Conversation

@kevindean12

@kevindean12 kevindean12 commented Nov 2, 2022 •

Copy link
Copy Markdown
Contributor

Introduces a TR_DisableIlgenOpts option flag that can be set in order to skip optimizations run during ilgen.

optimizer = TR::Optimizer::createOptimizer(comp, self(), true);
previousOptimizer = comp->getOptimizer();
comp->setOptimizer(optimizer);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to discover there isn't a means to disable this already. I did find two unused functions allowIlGenOptimizations() that nothing in OMR nor any known downstream project uses, but I'd have to dig into the intent of those functions to know if, ultimately, those are the right functions to use.

In the meantime, for your case, can you rename your option TR_DisableIlgenOpts to be more consistent with other options for disabling features?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I've updated the option name!

@0xdaryl 0xdaryl self-assigned this Nov 29, 2022
Comment thread compiler/control/OMROptions.cpp Outdated
TR::Options::setStaticNumericKBAdjusted, (intptr_t)&OMR::Options::_scratchSpaceLowerBound, 0, "F%d (bytes)"},
{"searchCount=", "O<nnn>\tcount of the max search to perform",
TR::Options::set32BitSignedNumeric, offsetof(OMR::Options,_lastSearchCount), 0, "F%d"},
{"skipIlgenOpts", "O\tDo not run the optimizer during ilgen", SET_OPTION_BIT(TR_DisableIlgenOpts), "F"},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the option name text here as well (and insert the new name alphabetically).

@0xdaryl

0xdaryl commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Please change the PR text as well to reflect the new option name.

-introduces a TR_DisableIlgenOpts option flag that can be set in order
to skip optimizations run during ilgen
@kevindean12

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@0xdaryl

0xdaryl commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

PPC failure is known.

@0xdaryl
0xdaryl merged commit 6ad6671 into eclipse-omr:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants