Repository navigation
Use LDE to load single precision floating point values - #6834
Conversation
|
@joransiu Can I get a review on this one ? |
joransiu
left a comment
There was a problem hiding this comment.
LGTM. @r30shah, can you double check with a test the long disp unresolved patching path is safe? Given RXE is not a common format, and it only has 12-bits of displacement, I worry we might missed something, which would be a hard bug to figure out in the field. From my review of the OpenJ9 PicBuilder code and its OOL long disp handling, it should all work, as we only patch up to 4K.
|
@joransiu Looking at the PIC builder code and the unresolved snippet we emit, it works well with RXE type instruction as well as you said. I have confirmed it with unit test. Though your comment When we generate binary, we see that the displacement is very large and we can not use the displacement field in the instruction, so in [2], it frees up a scratch register and uses Please notice, we free up GPR2 by spilling it onto the stack but do no preserve it back. Such touch up for the long displacement is handled in [3] but for RXE type instruction we actually never call it 😞 I have updated the instruction api for RXE type instruction to call this routine to restore spilled register in f76bd35 Relaunching tests, Marking it WIP while they finish [1]. https://github.com/eclipse/omr/blob/310f0efc871923145d85dd1f450b6a08dd11ef35/compiler/z/codegen/OMRMemoryReference.cpp#L2919 |
LE instruction on IBM Z loads single precision floating values into the FPR register. In certain scenarios this operation may perform poorly espcecially in case of Write after Read or Write after Write scenario where hardware may not be able to break the dependency chain. In such scenarios, using LDE instruction to load from memory would help. This commit replaces the use of LE instruction with LDE. Also while testing the changes we found out that for RXE type instructions we were not handling long displcement correctly and introducing a bug where it would store the scratch register to stack but does not restore it back. It is fixed in this commit. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
f76bd35 to
7b8e9ac
Compare
|
@joransiu change in I have tested out this changes with Java 8 Personal build ( This one is ready for review, I am launching OMR tests on this |
|
Jenkins build zos,zlinux |
joransiu
left a comment
There was a problem hiding this comment.
LGTM. Nice catch on the long disp fixup!
|
@0xdaryl Can I request you to merge this change? |
LE instruction on IBM Z loads single precision floating values into the FPR register. In certain scenarios this operation may perform poorly espcecially in case of Write after Read or Write after Write scenario where hardware may not be able to break the dependency chain. In such scenarios, using LDE instruction to load from memory would help. This commit replaces the use of LE instruction with LDE.
Signed-off-by: Rahil Shah rahil@ca.ibm.com