Skip to content

Add information on lastOptSubIndex - #6854

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:doc-ProblemDetermination
Jan 27, 2023
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:doc-ProblemDetermination

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

This update captures a discussion on Slack on how to use lastOptIndex and lastOptSubIndex to control performTransformation to skip optional opt passes to narrow down compilation issues.

Co-Authored-By: Devin Papineau devin@ajdmp.ca

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

@a7ehuo

a7ehuo commented Dec 20, 2022

Copy link
Copy Markdown
Contributor Author

@0xdaryl May I ask you to review? Thank you!
@jdmpapin fyi

@a7ehuo a7ehuo changed the title Add information on lastOptIndex Add information on lastOptSubIndex Dec 20, 2022
@a7ehuo

a7ehuo commented Jan 20, 2023

Copy link
Copy Markdown
Contributor Author

@0xdaryl @jdmpapin Just following up. Is there any review comment on this update? Thanks

@a7ehuo
a7ehuo force-pushed the doc-ProblemDetermination branch from 6c7948e to f92e94f Compare January 20, 2023 16:08

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Just some minor suggestions about wording and clarification.

Comment thread doc/compiler/ProblemDetermination.md Resolved
Comment thread doc/compiler/ProblemDetermination.md Resolved
Comment thread doc/compiler/ProblemDetermination.md Resolved
Comment thread doc/compiler/ProblemDetermination.md Resolved
Comment thread doc/compiler/ProblemDetermination.md Resolved
Comment thread doc/compiler/ProblemDetermination.md Resolved
Comment thread doc/compiler/ProblemDetermination.md Resolved
@a7ehuo
a7ehuo force-pushed the doc-ProblemDetermination branch from f92e94f to cb7e25d Compare January 24, 2023 15:48
@a7ehuo

a7ehuo commented Jan 24, 2023

Copy link
Copy Markdown
Contributor Author

@hzongaro All comments are addressed. Ready for another review!

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this late additional comment about performOptimization. It hadn't occurred to me before that the existing documentation only talked about performTransformation, but not the higher level performOptimization.

Comment thread doc/compiler/ProblemDetermination.md Resolved
Comment thread doc/compiler/ProblemDetermination.md Resolved
This update captures a discussion on Slack on how to
use `lastOptIndex` and `lastOptSubIndex` to control
`performTransformation` to skip optional opt passes to
narrow down compilation issues.

Co-Authored-By: Devin Papineau <devin@ajdmp.ca>

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo force-pushed the doc-ProblemDetermination branch from cb7e25d to 75e009b Compare January 24, 2023 18:38
@a7ehuo

a7ehuo commented Jan 24, 2023

Copy link
Copy Markdown
Contributor Author

@hzongaro All comments are addressed. Ready for another review. Thanks!

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@0xdaryl 0xdaryl self-assigned this Jan 27, 2023
@0xdaryl
0xdaryl merged commit 4c214a8 into eclipse-omr:master Jan 27, 2023
@a7ehuo
a7ehuo deleted the doc-ProblemDetermination branch June 6, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants