Repository navigation
Add information on lastOptSubIndex - #6854
Merged
Merged
Conversation
a7ehuo
requested review from
0xdaryl,
charliegracie and
mstoodle
as code owners
December 20, 2022 21:27
Contributor
Author
Contributor
Author
a7ehuo
force-pushed
the
doc-ProblemDetermination
branch
from
January 20, 2023 16:08
6c7948e to
f92e94f
Compare
hzongaro
reviewed
Jan 23, 2023
hzongaro
left a comment
Contributor
There was a problem hiding this comment.
Looks very good. Just some minor suggestions about wording and clarification.
a7ehuo
force-pushed
the
doc-ProblemDetermination
branch
from
January 24, 2023 15:48
f92e94f to
cb7e25d
Compare
Contributor
Author
|
@hzongaro All comments are addressed. Ready for another review! |
hzongaro
reviewed
Jan 24, 2023
hzongaro
left a comment
Contributor
There was a problem hiding this comment.
Sorry for this late additional comment about performOptimization. It hadn't occurred to me before that the existing documentation only talked about performTransformation, but not the higher level performOptimization.
This update captures a discussion on Slack on how to use `lastOptIndex` and `lastOptSubIndex` to control `performTransformation` to skip optional opt passes to narrow down compilation issues. Co-Authored-By: Devin Papineau <devin@ajdmp.ca> Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
doc-ProblemDetermination
branch
from
January 24, 2023 18:38
cb7e25d to
75e009b
Compare
Contributor
Author
|
@hzongaro All comments are addressed. Ready for another review. Thanks! |
0xdaryl
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update captures a discussion on Slack on how to use
lastOptIndexandlastOptSubIndexto controlperformTransformationto skip optional opt passes to narrow down compilation issues.Co-Authored-By: Devin Papineau devin@ajdmp.ca
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com