Repository navigation
Revert "Replace sprintf() in pugixml with snprintf()" - #6889
Merged
Merged
Conversation
knn-k
requested review from
0xdaryl,
charliegracie and
mstoodle
as code owners
February 15, 2023 13:20
0xdaryl
approved these changes
Feb 15, 2023
Contributor
|
Can I request that the branch "revert-6881-useSnprintfPugixml" be deleted now that it is merged? Thanks. |
Contributor
Author
|
I deleted the branch. |
Contributor
Thank you. Ideally, the branch would have been in your fork instead of this shared repository to avoid copies of the branch in mirrors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6881