Skip to content

Fix check on virtualCallNodeForAGuardedInlinedCall - #7086

Merged
jdmpapin merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:fix-isTheVirtualCallNodeForAGuardedInlinedCall
Aug 14, 2023
Merged

jdmpapin merged 1 commit into
eclipse-omr:masterfrom
a7ehuo:fix-isTheVirtualCallNodeForAGuardedInlinedCall

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

virtualCallNodeForAGuardedInlinedCall shares the same value as dontTransformArrayCopyCall: 0x00000800.

Just checking isCall() is not enough to determine if it's indeed virtualCallNodeForAGuardedInlinedCall.

`virtualCallNodeForAGuardedInlinedCall` shares the same
value as `dontTransformArrayCopyCall`: `0x00000800`.

Just checking `isCall()` is not enough to determine
if it's indeed `virtualCallNodeForAGuardedInlinedCall`.

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo requested review from jdmpapin and removed request for Leonardo2718 and vijaysun-omr August 10, 2023 13:38
@a7ehuo

a7ehuo commented Aug 10, 2023

Copy link
Copy Markdown
Contributor Author

@jdmpapin May I ask you to review this change? Thank you!
@hzongaro fyi

@jdmpapin jdmpapin self-assigned this Aug 11, 2023
@jdmpapin

jdmpapin commented Aug 11, 2023 •

Copy link
Copy Markdown
Contributor

Jenkins test all

@jdmpapin

jdmpapin commented Aug 11, 2023 •

Copy link
Copy Markdown
Contributor

The Mac failure is #6516 - edit: restarted

@jdmpapin

Copy link
Copy Markdown
Contributor

Jenkins build all

@jdmpapin
jdmpapin merged commit d44b9a1 into eclipse-omr:master Aug 14, 2023
@a7ehuo
a7ehuo deleted the fix-isTheVirtualCallNodeForAGuardedInlinedCall branch March 6, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants