Repository navigation
Fix issue in folding the conditional in the duplicated loop - #7155
Merged
vijaysun-omr merged 1 commit intoOct 30, 2023
Merged
vijaysun-omr merged 1 commit into
vijaysun-omr merged 1 commit into
Conversation
Contributor
Author
Contributor
|
LGTM, but I've already been very involved with this fix, to the point that I've been listed as a co-author of the commit. (BTW, GitHub only recognizes the So @vijaysun-omr would you mind reviewing this one? |
a7ehuo
force-pushed
the
fix-loop-versioner-FoldConditional-pr
branch
from
October 25, 2023 15:01
36ca08b to
88c3544
Compare
It is incorrect to both version asynch check and fold the conditional in the duplicated loop, or version write barrier and fold the conditional in the duplicated loop. For asynch check, when the loops are unbiased, do not version asynch check so that the conditional in both loops can be folded away. For write barriers, the determination of whether or not to version write barriers happens after the duplicated loop has already been added to `FoldConditional`. If the conditional in the duplicated loop will be folded, do not version write barrier. Fixes eclipse-openj9/openj9#17249 Co-Authored-By: Devin Papineau <devin@ajdmp.ca> Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
fix-loop-versioner-FoldConditional-pr
branch
from
October 25, 2023 15:01
88c3544 to
250f161
Compare
Contributor
Author
250f161 is updated to have the correct format |
vijaysun-omr
approved these changes
Oct 30, 2023
Contributor
|
jenkins build all |
Contributor
|
jenkins build riscv |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is incorrect to both version asynch check and fold the conditional in the duplicated loop, or version write barrier and fold the conditional in the duplicated loop.
For asynch check, when the loops are unbiased, do not version asynch check so that the conditional in both loops can be folded away.
For write barriers, the determination of whether or not to version write barriers happens after the duplicated loop has already been added to
FoldConditional. If the conditional in the duplicated loop will be folded, do not version write barrier.Fixes eclipse-openj9/openj9#17249