Repository navigation
Do not swing down volatile nodes - #7281
Merged
vijaysun-omr merged 1 commit intoMar 7, 2024
Merged
Conversation
Volatile nodes should always be anchored under a treetop to avoid any interference with other optimization passes (e.g. PRE). Fixes eclipse-openj9/openj9#18777 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
Contributor
Author
|
An example of with this change Without this change (baseline), a load of volatile symbol With this change, a load of volatile symbol |
Contributor
Author
|
@vijaysun-omr May I ask you to review this change? Thank you! @hzongaro fyi |
Contributor
|
jenkins build all |
vijaysun-omr
approved these changes
Mar 7, 2024
Contributor
|
jenkins build win |
Contributor
|
Test have passed apart from known issues. The change is a conservative one that is cross platform. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volatile nodes should always be anchored under a treetop to avoid any interference with other optimization passes (e.g. PRE).
Fixes eclipse-openj9/openj9#18777