Skip to content

Fix explanation for enableGuardedCountingRecompilation - #7287

Merged
dsouzai merged 1 commit into
eclipse-omr:masterfrom
jmesyou:docs/options/gcr
Mar 21, 2024
Merged

dsouzai merged 1 commit into
eclipse-omr:masterfrom
jmesyou:docs/options/gcr

Conversation

@jmesyou

@jmesyou jmesyou commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@jmesyou
jmesyou requested a review from dsouzai as a code owner March 21, 2024 14:39
@dsouzai dsouzai self-assigned this Mar 21, 2024
@dsouzai

dsouzai commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

jenkins build all

Comment thread compiler/control/OMROptions.cpp Resolved

@dsouzai dsouzai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna risk sounding pendantic, but I suggested some changes to improve the clarity a tad.

Comment thread compiler/control/OMROptions.cpp Resolved
Comment thread compiler/control/OMROptions.cpp Resolved
Signed-off-by: James You <james.you@protonmail.com>
@jmesyou
jmesyou requested a review from dsouzai March 21, 2024 15:39
@dsouzai

dsouzai commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

jenkins build all

@dsouzai

dsouzai commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

Not really sure about the riscv test failure:

12:27:13  29: �[0;32m[  PASSED  ] �[m156911 tests.
12:27:13  29: �[0;32m[  ALL TESTS PASSED  ] 
12:27:56  29: �[m
12:27:56  29/30 Test #29: comptest ..........................Child killed***Exception: 1455.81 sec

but this PR's changes can't impact that.

macos failure due to #7181

@dsouzai
dsouzai merged commit 622e8ea into eclipse-omr:master Mar 21, 2024
@jmesyou
jmesyou deleted the docs/options/gcr branch March 21, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants