Skip to content

Add option to enable Code Cache disclaiming - #7324

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
gita-omr:disclaim_cold_cache
May 8, 2024
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
gita-omr:disclaim_cold_cache

Conversation

@gita-omr

Copy link
Copy Markdown
Contributor

No description provided.

@0xdaryl

0xdaryl commented May 6, 2024

Copy link
Copy Markdown
Contributor

Should "cold" be in the option name if this is specific to cold code cache disclaiming? i.e., enableColdCodeCacheDisclaiming

@gita-omr

gita-omr commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

Should "cold" be in the option name if this is specific to cold code cache disclaiming? i.e., enableColdCodeCacheDisclaiming

Good question. I deliberately made it more general in case we want to experiment and disclaim warm code as well.

@0xdaryl 0xdaryl self-assigned this May 8, 2024
@0xdaryl

0xdaryl commented May 8, 2024

Copy link
Copy Markdown
Contributor

I deliberately made it more general in case we want to experiment and disclaim warm code as well.

OK, but I'm worried we won't remember to update the option description in the future if and when that happens. If that's your plan, can you drop "cold" from the option description text then?

@gita-omr
gita-omr force-pushed the disclaim_cold_cache branch from e69f86d to 9b726ba Compare May 8, 2024 21:29
@gita-omr

gita-omr commented May 8, 2024

Copy link
Copy Markdown
Contributor Author

Removed "cold" from option description.

@0xdaryl

0xdaryl commented May 8, 2024

Copy link
Copy Markdown
Contributor

Only change since CI last ran was to the contents of a C string. Re-running CI is not necessary.

@0xdaryl
0xdaryl merged commit 9a431c4 into eclipse-omr:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants