Repository navigation
Set nodeCountThreshold to 16k for >= hot compilations - #7337
Conversation
Set nodeCountThreshold to 16k for hot or above method compilations. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
|
@mpirvu Can I get your review on this change ? |
|
Jenkins build all |
|
@AdamBrousseau Seems like riscV 64 build is stuck waiting for nodes which are offline (https://ci.eclipse.org/omr/job/PullRequest-linux_riscv64_cross/1400/), is there a workaround for that? |
|
@vijaysun-omr Seems like only remaining build is riscv-64 for which both machine where it can be run are offline which not sure will be resolved soon. |
|
Given the comments from Rahil, and my review of this purely heuristic change to the inliner, I feel it is very likely that the testing on RISC-V would not throw up any new issues. I am merging this change on that basis rather than hold up for infra reasons. |
|
Hi @JamesKingdon , yes I believe the main intention of the change in #7240 was to lower the count for all compiles and let the consumer like OpenJ9 to set the threshold for the compiles, but we do not do that in OpenJ9 and it is only done when an environment option |
Set nodeCountThreshold to 16k for hot or above method compilations.