Skip to content

Fix trace format for MemorySubSpace - #7381

Merged
babsingh merged 1 commit into
eclipse-omr:masterfrom
amicic:fix_trace_format_MemeorySubSpace
Jun 17, 2024
Merged

babsingh merged 1 commit into
eclipse-omr:masterfrom
amicic:fix_trace_format_MemeorySubSpace

Conversation

@amicic

@amicic amicic commented Jun 17, 2024 •

Copy link
Copy Markdown
Contributor

Various trace points use %llx (long long - 64bit) while it should use
%zx or %p (size_t - 32/64 bit) format to print MemorySubSpace addresses
and allocation result (address in heap), what would work both for 32bit
and 64bit VMs. Settling with %p, since it's already predominant.

@amicic amicic added the comp:gc label Jun 17, 2024
@amicic

amicic commented Jun 17, 2024

Copy link
Copy Markdown
Contributor Author

@dmitripivkine please, review

Various trace points use %llx (long long - 64bit) while it should use
%zx or %p (size_t - 32/64 bit) format to print MemorySubSpace addresses
and allocation result (address in heap), what would work both for 32bit
and 64bit VMs. Settling with %p, since it's already predominant.

Signed-off-by: Aleksandar Micic <Aleksandar_Micic@ca.ibm.com>
@amicic
amicic force-pushed the fix_trace_format_MemeorySubSpace branch from 0b6c452 to de2d500 Compare June 17, 2024 18:27
@dmitripivkine

Copy link
Copy Markdown
Contributor

@babsingh Would you please help with merging?

@babsingh

Copy link
Copy Markdown
Contributor

jenkins build all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants