Skip to content

Fix and improve debug counters for failed call sites - #7410

Merged
0xdaryl merged 2 commits into
eclipse-omr:masterfrom
jdmpapin:failed-callsite-debug-counters
Jul 30, 2024
Merged

0xdaryl merged 2 commits into
eclipse-omr:masterfrom
jdmpapin:failed-callsite-debug-counters

Conversation

@jdmpapin

Copy link
Copy Markdown
Contributor
  • Create debug counters correctly for removed call sites
  • Specify the current compilation in failed call site debug counter names

jdmpapin added 2 commits July 17, 2024 12:07
This was passing callsite->_callNodeTreeTop while it was still null,
which prevented the debug counter increment from being generated and
even prevented a static debug counter increment.

The treetop where the call occurs is tt, and in this case callsite is
the result of searching for a dead call site that matches it. This tt
is already used for the Unresolved_In_ECS case, and it's also the value
that callsite->_callNodeTreeTop would take on just below if callsite
hadn't been removed.
This way, if a particular failure reason is of interest, the debug
counters will list all of the methods in which inlining failed for that
reason.
@jdmpapin
jdmpapin requested a review from vijaysun-omr as a code owner July 17, 2024 16:09
@0xdaryl 0xdaryl self-assigned this Jul 30, 2024
@0xdaryl

0xdaryl commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl
0xdaryl merged commit a0f9acd into eclipse-omr:master Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants