Repository navigation
Add Xgc options for suballocator heap size and quick allocation - #7414
Conversation
|
FYI @babsingh This relates to #7190 (comment) However, there are a few issues that arose during testing. The patch adds fields to the In
I am trying to figure out where/when the best time to set these Update edit: |
Try setting PPG values before |
The problem is that we need to update the PPG values on the I've got something working where the The only potential issue that I see with this is that there is more control flow in every call to |
597a9cb to
c9bfe5f
Compare
babsingh
left a comment
There was a problem hiding this comment.
Minor formatting nitpicks.
|
@keithc-ca @dmitripivkine Can you also review this PR? |
|
@amicic FYI |
A dependency in that direction is not reasonable; and cyclic dependencies even less so. |
c9bfe5f to
b1989ce
Compare
8be8a2f to
576481c
Compare
|
@0xdaryl could you start testing and get this merged? |
576481c to
8f080f4
Compare
|
Jenkins build all Running initial testing on commits that are here. |
8f080f4 to
3a236eb
Compare
|
I had forgotten to add some |
|
Jenkins build all |
3a236eb to
f8b11d5
Compare
|
Jenkins build all |
|
Who can I contact about the CI machines? The windows machines have been offline for a while now. |
|
re/ Windows CI machines. They were offline pending critical security updates. I understand that's been completed, but additional work needs to be done to verify that and get them back online. |
|
Adam told me that there is no ETA for the Windows machines to be back online. All of the other ci builds passed. I have one more commit to push addressing Keith's issues with the comments. They won't affect the behaviour at all so I don't think we need to rerun all the builds. |
1. Use VMEM_ALLOC_QUICK by default for allocateRegion in allocate_memory32 2. Adds -Xgc:suballocatorQuickAllocDisable option that disables the default VMEM_ALLOC_QUICK 3. Adds -Xgc:suballocatorIncrementSize option that replaces the HEAP_SIZE_BYTES macro and controls the heap increment size 4. Adds an omrport_copy_suballocator_globals procedure that correctly initializes the PPG suballoctor globals for memCheckPortLib when -Xcheck is provided 5. Updates related documentation Addresses: eclipse-omr#7190 Signed-off-by: Nathan Henderson <nathan.henderson@ibm.com>
f8b11d5 to
f38831a
Compare
|
@keithc-ca : please formally approve if you're OK with the final changes |
|
These changes are causing failures on AIX across all Java versions. I created a build without this change and the failing tests pass. I'm creating a revert PR so we can get the pending OMR changes promoted. |
This happens when |
allocate_memory32
disables the default VMEM_ALLOC_QUICK
HEAP_SIZE_BYTES macro and controls the heap increment size
initializes the PPG suballoctor globals for memCheckPortLib when
-Xcheck is provided
Addresses: #7190
Signed-off-by: Nathan Henderson nathan.henderson@ibm.com