Repository navigation
Modifications for Off-Heap Technology for Large Arrays - #7421
Conversation
|
@amicic @dmitripivkine please review the changes, Thanks |
| #if defined(OMR_GC_DOUBLE_MAP_ARRAYLETS) | ||
| , isArrayletDoubleMapRequested(false) | ||
| , isArrayletDoubleMapAvailable(false) | ||
| #endif /* defined(OMR_GC_DOUBLE_MAP_ARRAYLETS) */ |
There was a problem hiding this comment.
These two fields are defined under the same flag. If if defined is removed here, it should be removed at fields definitions as well.
There was a problem hiding this comment.
good observation. a preference is to keep the ifdefs if possible (if there are no spots in any current or more importantly new code that uses the variables without being wrapped with the same build flag)
| TraceEvent=Trc_MM_clearheap Overhead=1 Level=1 Group=gclogger Template="clearheap with free memory size: %zu, object size: %zu" | ||
| TraceEvent=Trc_MM_cleanUpSegmentsInAnonymousClassLoader_stats Overhead=1 Level=1 Group=gclogger Template="Anonymous classes: total: %zu, unloaded: %zu, searched ROM: %zu, found ROM fast: %zu, found ROM slow: %zu, not found ROM: %zu" | ||
|
|
||
| TraceEntry=Trc_MM_double_map_EntryNew Overhead=1 Level=3 Group=arraylet Template="MM_IndexableObjectAllocationModel::doubleMapArraylets. originalDataSize: %p, adjustedDataSize: %p, spine: %p, leafSize: %p leavesCount: %zu" |
There was a problem hiding this comment.
we have to remember to obsolete the old one, once all (downstream) usages are updated
| } | ||
|
|
||
| bool | ||
| MM_GCExtensionsBase::isAddressWithinHeap(void *address) |
There was a problem hiding this comment.
let's try without introducing this method. instead, we can do:
- simplest from testing perspective, but probably least desirable, introduce it on J9 side
- use (NULL != regionManager->regionDescriptorForAddress()) instead, which probably also a reasonable simple compromise
- examine the caller sites more carefully and see if it's really need at all, or if we can use isDataAddr(Non)Adjacent instead (requires extra non-trivial testing)
705879b to
9aa91c8
Compare
| , isArrayletDoubleMapRequested(false) | ||
| , isArrayletDoubleMapAvailable(false) | ||
| #endif /* defined(OMR_GC_DOUBLE_MAP_ARRAYLETS) */ | ||
| #endif /* OMR_GC_DOUBLE_MAP_ARRAYLETS */ |
There was a problem hiding this comment.
removed 'defined()', let's restore the line to what exactly it was
4ea093f to
52bea29
Compare
9441e75 to
1a8295b
Compare
|
@0xdaryl please, review JIT changes, or if you prefer, arrange a separate PR |
1a8295b to
94fbd3f
Compare
Modifications required to complete the introduction of an optimized memory management scheme for large arrays in a region-based garbage collector. More specifically, this is a new heap scheme and large object organization (in-heap and off-heap), an enhanced method for allocating large objects (proxy objects), and an optimized technique of accessing large arrays during runtime (JIT optimizations). - new define OMR_GC_SPARSE_HEAP_ALLOCATION - set OMR_GC_SPARSE_HEAP_ALLOCATION ON - obsolete Trc_MM_double_map_Entry, once all usages are updated. - replace J9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATION with OMR_GC_SPARSE_HEAP_ALLOCATION. - empty method offsetOfContiguousDataAddrField() in ObjectModel - empty method generateArrayElementShiftAmountTrees() in TransformUtil - empty method isOffHeapAllocationEnabled() in ObjectModel Signed-off-by: hulin <linhu@ca.ibm.com>
94fbd3f to
982a33b
Compare
|
Jenkins build all |
|
@LinHu2016 : I see you've pushed recently. Does this require a GC re-review or are you just addressing Alek's comments? |
|
No further changes are required. |
Modifications required to complete the introduction of an optimized
memory management scheme for large arrays in a region-based
garbage collector.
More specifically, this is a new heap scheme and large
object organization (in-heap and off-heap), an
enhanced method for allocating large objects (proxy
objects), and an optimized technique of accessing
large arrays during runtime (JIT optimizations).
OMR_GC_SPARSE_HEAP_ALLOCATION.
Signed-off-by: hulin linhu@ca.ibm.com